Skip to content

fix: release initial superblock after rotation - #74

Merged
bmuddha merged 1 commit into
feat/fjall-index-migrationfrom
fix/release-superblock-on-rotation
Aug 20, 2026
Merged

fix: release initial superblock after rotation#74
bmuddha merged 1 commit into
feat/fjall-index-migrationfrom
fix/release-superblock-on-rotation

Conversation

@bmuddha

@bmuddha bmuddha commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Move the initial active superblock handle into SuperblockWriter after creating the Fjall index writer.
  • Allow rotation to release the appender's last reference to the previous superblock.

Closes #73

Impact

Truncated initial-superblock files, metadata mappings, and Fjall keyspace references can be reclaimed without restarting Engine. There are no API, storage-format, or compatibility changes.

Reviewer notes

IndexWriter retains its own Fjall keyspace handle and does not require the enclosing Arc<Superblock>. SuperblockWriter remains the sole appender-owned superblock handle and releases it when rotation replaces the writer.

@bmuddha bmuddha added the bug Something isn't working label Aug 20, 2026
@bmuddha bmuddha self-assigned this Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bmuddha, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f1e6612-f6ec-4fe9-867a-c4ef8e885892

📥 Commits

Reviewing files that changed from the base of the PR and between 63f155b and b19526f.

📒 Files selected for processing (1)
  • ledger/src/appender.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bmuddha
bmuddha force-pushed the fix/release-superblock-on-rotation branch from caa1cc4 to 065fe43 Compare August 20, 2026 13:43
@bmuddha
bmuddha marked this pull request as ready for review August 20, 2026 13:45
@bmuddha
bmuddha force-pushed the fix/release-superblock-on-rotation branch from 065fe43 to b19526f Compare August 20, 2026 13:59
@bmuddha
bmuddha merged commit 3ebd73a into dev Aug 20, 2026
4 checks passed
@bmuddha
bmuddha deleted the fix/release-superblock-on-rotation branch August 20, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ledger appender retains the initial superblock until shutdown

1 participant