feat: replace ledger LMDB index with Fjall - #70
Closed
bmuddha wants to merge 2 commits into
Closed
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 19, 2026
Qualify the validator with 40 million Redline transactions
magicblock-labs/magicblock-validator#1564
Closed
Collaborator
Author
|
superseded with #71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pubkey_prefix || execution_spankeys with empty values.nucleusinto AccountsDB's index module.Closes #62
Impact
The ledger index format is intentionally incompatible with existing LMDB ledgers and has no migration path. Blockstore and execution stream formats are unchanged. Ordinary block publication avoids per-block device synchronization; explicit strong boundaries retain data-sync durability. Fjall LZ4 compression remains disabled because the realistic fixture reduced closed-directory size by only 7.37%.
Reviewer notes
The highest-risk invariants are cross-keyspace batch publication, reverse ordering and exclusive pagination for account history, and metadata publication only after the selected file/index durability boundary. Retention removes metadata durably before synchronously purging the sealed directory.