feat: undelegate during finalize for validator requests

[snawaz]

#184 undelegates accounts during finalization for the undelegation requests that come from the owner-program. This PR extends that to the requests that come from the validator. So this PR effectively makes the standalone Undelegate instruction obsolete.

In other words:

• Older 3 ix-set Commit + Finalize + Undelegate becomes 2 ix-set Commit + Finalize.
• Older 2 ix-set CommitFinalize + Undelegate becomes 1 ix-set CommitFinalize.

This PR is 100% binary backward-compatible.

[coderabbitai]

Warning

Review limit reached

@snawaz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7c47f6ff-cf0d-4467-9e83-b282e7a96254

📥 Commits

Reviewing files that changed from the base of the PR and between 72af1c7 and ccb7d57.

📒 Files selected for processing (9)

• dlp-api/src/state/delegation_metadata.rs
• src/processor/fast/internal/undelegate_internal.rs
• tests/test_call_handler.rs
• tests/test_call_handler_v2.rs
• tests/test_commit_finalize.rs
• tests/test_commit_finalize_from_buffer.rs
• tests/test_lamports_settlement.rs
• tests/test_request_undelegation.rs
• tests/test_undelegate.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch snawaz/undelegate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[snawaz]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat: undelegate during finalize for validator requests #186 👈 (View in Graphite)
• feat: auto-undelegate owner-program requests during finalize #184
• feat: Impl RequestUndelegation and UndelegateWithRollbackAfterTimeout #183 : 1 other dependent PR (#185 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[snawaz]

discarded because the idea of undelegation in finalize step is discarded.