Port Chrome extension to Manifest V3#116
Draft
chtx wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a draft Manifest V3 port for the Chrome build while keeping Firefox on Manifest V2.
The goal is to keep the extension usable in Chromium browsers after MV2 deprecation.
Architectural Changes
browserAction/actiontabs.executeScript/scripting.executeScripttabs.insertCSS/scripting.insertCSSMAINworld script injection for Chromium MV3 instead of inline page-script injection.Testing
Tested locally with:
npm testAlso tested manually in Brave (Chromium) and Firefox via unpacked developer install.
Known Issues
Could not establish connectionorExtension context invalidated. These seem to come from content scripts being torn down while the background worker is still sending cleanup messages.