Skip to content

feature: migrate to npm workspaces #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levivilet merged 1 commit into from
Jul 26, 2026
Merged

feature: migrate to npm workspaces #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
path: '**/node_modules'
key: ${{ runner.os }}-cacheNodeModules-${{ steps.nodeModulesCacheKey.outputs.value }}
- name: npm ci
run: npm ci --ignore-scripts && npm run postinstall
run: npm ci
if: steps.npm-cache.outputs.cache-hit != 'true'
- run: npm run build
- run: npm run build:static
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
path: '**/node_modules'
key: ${{ runner.os }}-cacheNodeModules-${{ steps.nodeModulesCacheKey.outputs.value }}
- name: npm ci
run: npm ci --ignore-scripts && npm run postinstall
run: npm ci
if: steps.npm-cache.outputs.cache-hit != 'true'
- run: npm run build
- run: npm run build:static
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
path: '**/node_modules'
key: ${{ runner.os }}-cacheNodeModules-${{ steps.nodeModulesCacheKey.outputs.value }}
- name: npm ci
run: npm ci --ignore-scripts && npm run postinstall
run: npm ci
if: steps.npm-cache.outputs.cache-hit != 'true'
- run: npm run build
- run: npm run build:static
Expand Down
2 changes: 1 addition & 1 deletion knip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"workspaces": {
".": {
"project": ["*.js"],
"ignoreDependencies": ["@lerna/legacy-package-management"]
"ignoreDependencies": []
},
"packages/build": {
"project": ["src/**/*.js", "src/**/*.ts"],
Expand Down
4 changes: 0 additions & 4 deletions lerna.json
View file
Open in desktop

This file was deleted.

20,925 changes: 11,452 additions & 9,473 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@
"license": "MIT",
"author": "Lvce Editor",
"type": "module",
"workspaces": [
"packages/*"
],
"scripts": {
"build": "node packages/build/src/build.ts",
"build:static": "node packages/build/src/build-static.ts",
"build:watch": "./packages/build/node_modules/.bin/esbuild --format=esm --bundle --external:node:buffer --external:electron --external:ws --external:node:worker_threads --watch packages/diff-view/src/diffViewWorkerMain.ts --outfile=.tmp/dist/dist/diffViewWorkerMain.js",
"build:watch": "npm run build:watch --workspace build",
"create:e2e-tests": "node packages/build/src/createE2ETests.ts",
"dev": "node packages/build/src/dev.ts",
"e2e": "cd packages/e2e && npm run e2e",
Expand All @@ -17,10 +20,9 @@
"e2e:webkit": "cd packages/e2e && npm run e2e:webkit",
"e2e:webkit:headless": "cd packages/e2e && npm run e2e:webkit:headless",
"format": "prettier --write .",
"postinstall": "lerna bootstrap --ci",
"lint": "eslint . && prettier --check . && npx --yes knip@6.20.0 --no-config-hints",
"test": "lerna run test",
"test-integration": "lerna run test-integration",
"test": "npm test --workspaces --if-present",
"test-integration": "npm run test-integration --workspaces --if-present",
"trigger-ci-branches": "bash packages/build/trigger-ci-branches.sh",
"type-check": "tsc -b"
},
Expand All @@ -30,10 +32,8 @@
"printWidth": 170
},
"devDependencies": {
"@lerna/legacy-package-management": "^8.2.4",
"@lvce-editor/eslint-config": "^17.5.0",
"eslint": "^10.8.0",
"lerna": "^8.2.3",
"prettier": "^3.9.5",
"typescript": "^6.0.3"
}
Expand Down
Loading