Add Taurus::XML.parse / parse_file module entry points - #14
Merged
Conversation
The README documents Taurus::XML.parse and Taurus::XML.parse_file,
but only Taurus::XML::Document.parse existed -- code following the
README raised NoMethodError. This surfaced when the serialbench
adapter probed availability with Taurus::XML.parse("<probe/>").
Adds Nokogiri-style module-level delegates (Nokogiri::XML(...)) to
Document.parse / Document.parse_file, with specs for string, IO,
and file input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/taurus/xml.rb: addTaurus::XML.parse/Taurus::XML.parse_filemodule-level delegates toDocument.parse/Document.parse_fileWhy
The README documents
Taurus::XML.parse(...)andTaurus::XML.parse_file(...)as the primary entry points, but the gem only shippedTaurus::XML::Document.parse— any code written from the README raisedNoMethodError. Found while wiring the serialbench adapter, whose availability probe callsTaurus::XML.parse('<probe/>').This also restores the Nokogiri ergonomics (
Nokogiri::XML(...)→Taurus::XML.parse(...)) promised by the migration guide.Test plan