security: brace-expansion 1.1.16 (Dependabot #12/#13, both manifests) - #5
Merged
Merged
Conversation
Fixes CVE-2025-5889 (brace-expansion 1.x ReDoS, vulnerable < 1.1.16). Within-major bump pinned via npm overrides scoped to the 1.x line ("brace-expansion@1": "1.1.16") so the callable minimatch@3-compatible default export is preserved. Applied to both npm projects: - ROOT package.json + package-lock.json (Dependabot #13) - mcp/lua-platform/package.json + package-lock.json (Dependabot #12) brace-expansion 1.1.14 -> 1.1.16 in both lockfiles. npm ci passes in both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Dependabot alerts #12 and #13 (brace-expansion, CVE-2025-5889 — 1.x ReDoS, vulnerable
< 1.1.16, first patched1.1.16).Fix
Within-major bump to
brace-expansion@1.1.16pinned via npmoverridesscoped to the 1.x line ("brace-expansion@1": "1.1.16"), extending the existing js-yaml override pattern. Scoping to@1keeps the callable, minimatch@3-compatible default export and does not disturb any 2.x/5.x. This is deliberately NOT the minimatch@10 / 5.0.8 cascade (CVE-2026-14257) — that would be an inappropriate over-fix here.Both manifests
package.json/package-lock.json(root)mcp/lua-platform/package.json/package-lock.jsonVerification
npm ciexits 0 in both the root andmcp/lua-platform/(lock ↔ pkg in sync).mcptypecheckreports TS18003 (no.tsinputs; project is.mjs) — not introduced by this change.Note
Low Risk
Lockfile-only security patch on a dev transitive dependency; no runtime or auth logic changes.
Overview
Addresses Dependabot alerts #12 and #13 by forcing transitive
brace-expansionon the 1.x line from 1.1.14 to 1.1.16 (CVE-2025-5889 ReDoS).Both
package.jsontrees (repo root andmcp/lua-platform) add an npmoverridesentry"brace-expansion@1": "1.1.16", matching the existing js-yaml override style and scoping to 1.x so minimatch@3’s dependency graph stays compatible. The pairedpackage-lock.jsonfiles are updated so installs resolve only 1.1.16.No application or build script source changes—dependency manifests and locks only.
Reviewed by Cursor Bugbot for commit 3f21f92. Bugbot is set up for automated code reviews on this repo. Configure here.