Repository navigation
feat(deploy): 1.11.0 — /lua-deploy webapp deploys just the web app (lua-cli 3.49.0+) - #21
Conversation
…ua-cli 3.49.0+) lua-cli 3.49.0 adds `lua deploy webapp`, a scoped promote like `lua deploy webhook`: only that web app's pin moves in a new agent version, nothing else staged goes live, a failed deploy changes nothing, and a disabled app is never switched on. - lua-deploy / lua-deploy-pilot: on 3.49.0+ push, then `LUA_DEPLOY_CONFIRMED=1 lua deploy webapp --ci --name <n> --set-version <v> --force`; below 3.49.0 the agent-version path with the diff-and-stop is kept. 503 SCOPED_PROMOTE_FAILED / 409 SCOPED_PROMOTE_CAP_EXHAUSTED are failed deploys; the switched-off warning is quoted; rollback = deploy the previous version (that app only). - lua-new, lua-push, lua-skill-builder, decision-trees, SECURITY: next step is /lua-deploy webapp. - web-apps.md: §7 rows for 3.49.0+ (deploy, rollback, switched off), agent-version rows kept for older CLIs; §3 Data.get example passes the filter as the second argument; note on the .default() typing of lua-cli 3.49.0 and earlier. - lint-knowledge-commands: deploy gains webapp. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
main released 1.10.0 with /lua-decisions (#22), so this PR takes 1.11.0: version in package.json, plugin.json, marketplace.json, the MCP package and its version strings; dist/server.js rebuilt; CHANGELOG entry above 1.10.0. lint-knowledge-commands: push gains decision (main's decisions docs use `lua push decision`; the check only runs when LUA_CLI_SRC is reachable, which is why main's CI did not catch it). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
bc5c5fd to
eaeb23c
Compare
richard-lua
left a comment
There was a problem hiding this comment.
Code review — LOW risk
This is a documentation and version-bump PR adding the lua-cli 3.49.0 lua deploy webapp scoped-promote path to the plugin's prompts, knowledge base, and lint allowlist, plus synchronized 1.10.0→1.11.0 version strings across every manifest, the MCP package, and the rebuilt bundle. The safety model is untouched: every production verb still carries the LUA_DEPLOY_CONFIRMED=1 prefix, the type-agnostic confirm-deploy hook needs no change, and no --auto-deploy is introduced. The guidance is internally consistent (deploy/push/new/skill-builder/decision-tree/SECURITY.md/web-apps.md all updated together) and correctly gates the new path behind a lua --version check with the agent-version fallback preserved for older CLIs.
Minor
scripts/lint-knowledge-commands.mjs:105—webappadded to thedeployallowlist with a 3.49.0 comment. Since the lint only runs whereLUA_CLI_SRCis reachable and uses a hand-curated set, confirm CI pins a lua-cli revision at/after 3.49.0 so the docs reference a command the CLI actually exposes.mcp/lua-platform/dist/server.js— the rebuilt bundle ships as a non-reviewable diff; confirm it was produced bynpm run buildand contains only the version-string changes reviewed inserver.mjs/api-client.mjs.
PR Risk Reviewer — automated senior review of eaeb23c · risk: low · confidence: 0.84
What
lua-cli 3.49.0 (now npm
latest; lua-core-services #5293) addslua deploy webapp. It is a scoped promote, likelua deploy webhook: a new agent version identical to the live one except that web app's pin is created and promoted. Nothing else staged on the agent goes live. A failed deploy changes nothing, and a disabled app is never switched on.Until now the plugin made a web app live by creating a whole agent version, diffing it against the live one, and stopping when anything other than web apps would change. That path stays for CLIs below 3.49.0.
commands/lua-deploy.md,agents/lua-deploy-pilot.mdLUA_DEPLOY_CONFIRMED=1 lua deploy webapp --ci --name <n> --set-version <v> --force. Below: the agent-version path with diff-and-stop, unchanged. The pilot readslua --versionbefore step 5. 503SCOPED_PROMOTE_FAILEDand 409SCOPED_PROMOTE_CAP_EXHAUSTEDare reported as failed deploys. The switched-off warning is quoted. The rollback line islua deploy webapp --set-version <previous>, which rolls back that app only.commands/lua-new.md,commands/lua-push.md,agents/lua-skill-builder.md,lib/knowledge/decision-trees.md,SECURITY.md/lua-deploy webapp, not/lua-deploy agent-version.lib/knowledge/web-apps.mdData.getexample passes the filter as the second argument (it showed{ filter: … }), plus a note on the.default()typing in lua-cli 3.49.0 and earlier (lua-core-services #5535 fixes it in the next release).scripts/lint-knowledge-commands.mjsdeploygainswebapp;pushgainsdecision. Main's decisions docs uselua push decision, and the check only runs whereLUA_CLI_SRCis reachable, so main's CI skipped it.main, where/lua-decisions#22 took 1.10.0) inpackage.json,plugin.json,marketplace.json, the MCP package, its version strings and the rebuiltdist/server.js; CHANGELOG entry above 1.10.0.Safety model unchanged. It is still one AskUserQuestion in
/lua-deploy, with every production verb carrying theLUA_DEPLOY_CONFIRMED=1prefix. Theconfirm-deployhook is type-agnostic, so it needs no change. No--auto-deployis added anywhere.Versioning: #18 (
fix/deploy-hook-false-positives) is still open and declares 1.7.1. If this PR merges first, #18 takes 1.11.1.Checks
npm run lintwithLUA_CLI_SRCpointing at lua-climain: clean.npm test: 68 suites, 2072 tests passed.🤖 Generated with Claude Code