SP-3313: review and improve the 301 series NBs

[jeffcarlin]

Made minor updates to use SkyCoord for calculating separations, and added some small science demos.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[GloriaFA]

Should the pipelines version be updated?

Reply via ReviewNB

[GloriaFA]

Line #19.        "Rubin_SV_320_-15": [320.2, -15.1, 4.51],

Would it make more sense to leave it as 4.5 to match the other fields?

Reply via ReviewNB

[jeffcarlin]

Unfortunately the number of visits I get with 4.5 is not the same as what's reported in the documentation (because when Melissa calculated those originally she used a different calculation). To get the numbers to match up I had to extend it to 4.51.

[GloriaFA]

Line #6.    tx = np.where(sc_region.separation(sc_patches).value <= rad)[0]

Is this supposed to be <= radius instead? The plot produced is more zoomed in and I wasn't sure if that was an intentional choice or a copy paste error.

tx = np.where(sc_region.separation(sc_patches).value <= radius)[0]

Though I noticed that doing this shows more patches around the corners than in the original notebook.

Reply via ReviewNB

[jeffcarlin]

Yes - good catch!

[GloriaFA]

Line #7.        # offsets = np.sqrt((joined_table['ra']-ra)**2 + (joined_table['dec']-dec)**2)

Forgot to remove commented out old code

Reply via ReviewNB

[GloriaFA]

Maybe "has few stellar features in the color-color diagrams"

Reply via ReviewNB

[GloriaFA]

Line #8.    #     delta_ra = (coords[0] - patches_table['s_ra'])*(np.cos(np.deg2rad(coords[1])))

Lines 8-11, forgot to remove commented out old code

Reply via ReviewNB

[GloriaFA]

Reviewed all 3 updated notebooks and left small comments.