[rom_ctrl, dv] rom_ctrl simulations ported to mocha#435
Draft
KolosKoblasz-Semify wants to merge 4 commits intolowRISC:mainfrom
Draft
[rom_ctrl, dv] rom_ctrl simulations ported to mocha#435KolosKoblasz-Semify wants to merge 4 commits intolowRISC:mainfrom
KolosKoblasz-Semify wants to merge 4 commits intolowRISC:mainfrom
Conversation
KolosKoblasz-Semify
force-pushed
the
kk_rom_ctrl_dv
branch
2 times, most recently
from
bb98462 to
eb4fb89
Compare
| {from: "hw/ip/kmac", to: "ip/kmac", patch_dir: "kmac"}, // kmac. | ||
| {from: "hw/ip/lc_ctrl", to: "ip/lc_ctrl"}, // Dependency of crossbar and power manager. | ||
| {from: "hw/ip/otp_ctrl", to: "ip/otp_ctrl"}, // otp_ctrl | ||
| {from: "hw/ip/rom_ctrl", to: "ip/rom_ctrl"}, // Read-only memory. |
Contributor
There was a problem hiding this comment.
You have created this patch hw/vendor/patches/lowrisc_ip/rom_ctrl/0001_Path_And_Dependency_Fixes.patch for the rom_ctrl but you haven't added the path to the directory. So the scripts to apply the patches cannot see your changes. You need to update this line like:
Suggested change
| {from: "hw/ip/rom_ctrl", to: "ip/rom_ctrl"}, // Read-only memory. | |
| {from: "hw/ip/rom_ctrl", to: "ip/rom_ctrl"", patch_dir: "rom_ctrl"}, // Read-only memory. |
KolosKoblasz-Semify
force-pushed
the
kk_rom_ctrl_dv
branch
from
eb4fb89 to
f52d1ce
Compare
KolosKoblasz-Semify
force-pushed
the
kk_rom_ctrl_dv
branch
from
f52d1ce to
846bb35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rom_ctrl module's simulations relay on OpenTitan project specific paths.
These are modified to fit into Mocha repo.