Remove use of actor registry and inject dependencies#234
Conversation
…l registry\n\nThis removes the `get_actor` mechanism and explicitly passes dependent actors (Tank, Swim, Heating, Disinfection, Arduino, Heater, Light) to the Filtration actor. State inspection is handled locally to prevent circular dependencies. Test coverage has also been significantly improved. Co-authored-by: lostcontrol <983305+lostcontrol@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Removes
get_actorcalls acrossFiltration,Tank,Heating, andSwimto eliminate global Actor Registry access, replacing it with explicit Dependency Injection via actor constructors inpoupool.py. The__notify_swimlogic ensures continuous state updates instead of polling, effectively resolving the circular dependency. Increased overallcontroller/test coverage to >60%.PR created automatically by Jules for task 18298035189000590608 started by @lostcontrol