Fix and improve robustness of Arduino cover logic#229
Conversation
- Fixed stale time variables in process_direction by using millis() - Protected 32-bit (long) non-atomic reads/writes in debug, get_position_percentage, reset, and set_limit with InterruptGuard to prevent ISR corruption. - Ensured EEPROM limit writes are guarded correctly. Co-authored-by: lostcontrol <983305+lostcontrol@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed race conditions and data corruption issues in the Arduino cover firmware by adding InterruptGuards around 32-bit integer reads/writes which could be corrupted by the encoder ISR. Also ensured precise timing using millis() instead of stale variables.
PR created automatically by Jules for task 4446708251437441680 started by @lostcontrol