test: remove stale README copy checks from showcase catalog smoke - #4969
Conversation
Signed-off-by: huangruiteng <14976749+huangruiteng@users.noreply.github.com>
huangruiteng
left a comment
There was a problem hiding this comment.
动机
精确 head 83cf792178da77bc31f0f6c5bd3ef61fbb4e8b94。当前主线 README 已更新定位文案,但 showcase catalog smoke 仍要求三处旧字串;基于同一主线的 #4945 checkout 实际以旧 tagline 的 AssertionError 退出。这条检查会阻断无关的 Frontstage Pages 构建。此 PR 是解除主线 CI 前置阻塞的独立、可回滚增量;它不代表投研团队产品旅程已验收。
改动思路
展示目录 smoke 继续负责公开案例链接、精选案例数量及证据目录;README 入口结构和当前“Recurring Work Presets”标题由既有 readme-demo-surface-smoke.py 检查。直接删去重复的精确文案断言,比把旧文案改成新文案更能避免下次编辑时同类失效。没有引入第二套规则或运行时状态。
具体改动
examples/showcase-catalog-smoke.py 仅删除三个断言:旧英文 tagline、旧产品定位句、旧 preset 标题;其余目录、案例与链接断言保留。没有生产代码、文档或生成文件变化。Frontstage Pages 工作流仍直接执行该 smoke。
对主干的风险
最主要的反例是未来 README 首屏内容变差而 catalog smoke 不再因精确措辞失败。该风险应由 README 入口检查和首屏 owner 预览承担,不能让目录测试冻结每次编辑文案。旧 checkout 对当前 README 的失败已复现;本 head 的 catalog smoke、README 入口 smoke、Pages 工作流 smoke、公开边界扫描和 diff 检查均通过。Goal 级 quick premerge 的 8 项检查通过,质量凭据 cqr_e10aec7a6329fc47da19 与本 head 匹配;无本地失败或手动 hold。本 Goal 的评审配置不等待远端 CI,因此这里不把 CI 状态当成已验证,也不据此授予合并权限。
我的整体评价
同意此精确 head 的测试修复。 这是三行删除、无运行时语义变化的合理收敛;同作者近期开放 PR 没有同形态 smoke 拆单。合并前仍须执行精确 head merge-readiness 与仓库合并规则,合并后重跑 #4945 的 Frontstage Pages;真实产品旅程验收继续保持开放。
English verdict: APPROVE - At 83cf792, the test-only deletion removes duplicated stale README copy checks while catalog and README entry coverage pass locally; merge readiness and the downstream Pages rerun remain separate gates.
huangruiteng
left a comment
There was a problem hiding this comment.
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机
精确 head 83cf792178da77bc31f0f6c5bd3ef61fbb4e8b94。当前主线 README 已更新定位文案,但 showcase catalog smoke 仍要求三处旧字串;基于同一主线的 #4945 checkout 实际以旧 tagline 的 AssertionError 退出。这条检查会阻断无关的 Frontstage Pages 构建。此 PR 是解除主线 CI 前置阻塞的独立、可回滚增量;它不代表投研团队产品旅程已验收。
改动思路
展示目录 smoke 继续负责公开案例链接、精选案例数量及证据目录;README 入口结构和当前“Recurring Work Presets”标题由既有 readme-demo-surface-smoke.py 检查。直接删去重复的精确文案断言,比把旧文案改成新文案更能避免下次编辑时同类失效。没有引入第二套规则或运行时状态。
具体改动
examples/showcase-catalog-smoke.py 仅删除三个断言:旧英文 tagline、旧产品定位句、旧 preset 标题;其余目录、案例与链接断言保留。没有生产代码、文档或生成文件变化。Frontstage Pages 工作流仍直接执行该 smoke。
对主干的风险
最主要的反例是未来 README 首屏内容变差而 catalog smoke 不再因精确措辞失败。该风险应由 README 入口检查和首屏 owner 预览承担,不能让目录测试冻结每次编辑文案。旧 checkout 对当前 README 的失败已复现;本 head 的 catalog smoke、README 入口 smoke、Pages 工作流 smoke、公开边界扫描和 diff 检查均通过。Goal 级 quick premerge 的 8 项检查通过,质量凭据 cqr_e10aec7a6329fc47da19 与本 head 匹配;无本地失败或手动 hold。本 Goal 的评审配置不等待远端 CI,因此这里不把 CI 状态当成已验证,也不据此授予合并权限。
我的整体评价
同意此精确 head 的测试修复。 这是三行删除、无运行时语义变化的合理收敛;同作者近期开放 PR 没有同形态 smoke 拆单。合并前仍须执行精确 head merge-readiness 与仓库合并规则,合并后重跑 #4945 的 Frontstage Pages;真实产品旅程验收继续保持开放。
English verdict: APPROVE - At 83cf792, the test-only deletion removes duplicated stale README copy checks while catalog and README entry coverage pass locally; merge readiness and the downstream Pages rerun remain separate gates.
|
Maintainer merge decision for exact head Local validation: catalog smoke, README entry smoke, Frontstage Pages workflow smoke, changed-file public scan, diff check, and goal-scoped quick premerge (8 selected/direct checks) passed. Exact-scope change-quality receipt |
The README positioning and preset heading changed on
main, butshowcase-catalog-smoke.pystill required the old text. That made the showcase check fail on an otherwise valid checkout and blocked unrelated PR CI. Remove those three presentation-copy assertions from the catalog smoke. The separate README entry smoke already checks the current README structure and recurring-work heading; the catalog smoke continues to verify showcase links and case coverage.Validation:
showcase-catalog-smoke.pyandreadme-demo-surface-smoke.pypass; changed-file public scan andgit diff --checkpass. Goal-scoped quick premerge passed all 8 selected/direct checks with no failures or manual holds. Exact-scope change-quality receipt:cqr_e10aec7a6329fc47da19.Future-facing pass: the two smokes now keep separate owners for catalog evidence and README entry structure. No new abstraction is needed.