feat!: remove all symbol↔counter_id conversions (port longbridge/openapi #562) - #119
Open
hogan-yuan wants to merge 1 commit into
Open
feat!: remove all symbol↔counter_id conversions (port longbridge/openapi #562)#119hogan-yuan wants to merge 1 commit into
hogan-yuan wants to merge 1 commit into
Conversation
…api #562) - Request params counter_id/counter_ids/underlying_counter_id -> symbol/symbols, sending the user-facing symbol as-is (AAPL.US, HSI.HK, BTCUSD.BKKT) - Responses read the server's symbol field directly (US assets: stock full_symbol, crypto symbol); removed all counter_id -> symbol response conversions - DELETE endpoints send parameters via query string and no longer send a body (alert ids, sharelist symbols; sharelist delete sends no body at all) - Removed the public counter package, internal/counter and QuoteContext.SymbolToCounterIds/ResolveCounterIds (symbol-to-counter-ids endpoint is no longer called) - fundamental.Ratings temporarily disabled (endpoint not yet open) - TopMoversResponse.NextParams is now a plain cursor string; portfolio flows ExecutedTimestamp normalized to string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports longbridge/openapi#562 to the Go SDK.
What changed
counter_id/counter_ids/underlying_counter_idquery/body params renamed tosymbol/symbols, sending the user-facing symbol as-is (AAPL.US,HSI.HK,BTCUSD.BKKT) instead of converting toST/US/AAPL/IX/HK/HSI/ETF/SH/513050/VA/BKKT/BTCUSD. Special cases:ValuationComparisoncomparison_counter_ids→comparison_symbols;USQueryOrdersbodycounter_ids→symbols.counter_id(and converted) now read the server'ssymboldirectly — executives, shareholders, fund holders, operatings, industry rank/peers, ETF asset allocation, DCA plans/records, sharelist members, alert groups, index constituents, anomaly/top-movers/rank-list, option-volume daily, US orders and US assets overview (USStockEntry.FullSymbol←full_symbol, crypto entries ←symbol).alert.Delete(ids) andsharelist.RemoveSecurities(symbols) now pass params via query string with no request body;sharelist.Deletesends no body.counterpackage,internal/counter(embedded US-ETF/IX/WT CSVs), andQuoteContext.SymbolToCounterIds/ResolveCounterIds(POST /v1/quote/symbol-to-counter-idsno longer called).fundamental.Ratings(GET /v1/quote/ratings) commented out — endpoint 暂不开放.TopMoversResponse.NextParams→ plain cursor string; portfolio flowsExecutedTimestampnormalized to string (int/string/null tolerated).Verification
go build ./.../go vet ./...pass (only pre-existingcopylockswarnings inquote/core.go)go test ./...passes except the pre-existingconfigTest_YamlConfigfailure (missingconfig/testdataonmainas well — unrelated)🤖 Generated with Claude Code