Skip to content

Responsible hide title bar and update packages#1214

Merged
GT-610 merged 1 commit into
mainfrom
hide-titlebar-response
Jun 27, 2026
Merged

Responsible hide title bar and update packages#1214
GT-610 merged 1 commit into
mainfrom
hide-titlebar-response

Conversation

@GT-610

@GT-610 GT-610 commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes

    • Changing the title bar visibility setting now updates the app’s window style immediately, so the interface reflects your choice right away.
    • SSH windows no longer force a fixed caption display, allowing the window frame to use its default behavior.
  • Chores

    • Updated an embedded library dependency to a newer revision.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6f9fea2e-57af-474c-8c23-7c668fbfa07c

📥 Commits

Reviewing files that changed from the base of the PR and between f33e421 and 17a304f.

⛔ Files ignored due to path filters (1)
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • lib/view/page/setting/entries/app.dart
  • lib/view/page/ssh/page/page.dart
  • packages/fl_lib
💤 Files with no reviewable changes (1)
  • lib/view/page/ssh/page/page.dart

📝 Walkthrough

Walkthrough

The _buildHideTitleBar method in the app settings page now includes an async callback on the StoreSwitch that calls SystemUIs.updateTitleBarStyle(hideTitleBar: value) when the toggle changes, applying the title bar style immediately at runtime. In SSHPage.restorableRouteBuilder, the showCaption: WindowFrameConfig.showCaption argument is removed from the VirtualWindowFrame constructor, leaving caption display to the widget's default behavior. The packages/fl_lib submodule reference is updated to a new commit.

Possibly related PRs

  • lollipopkit/flutter_server_box#1021: Both PRs modify the hideTitleBar path, with that PR wiring hideTitleBar into WindowFrameConfig.setShowCaption and updating fl_lib.
  • lollipopkit/flutter_server_box#1205: Both PRs modify SSHPage.restorableRouteBuilder in lib/view/page/ssh/page/page.dart, specifically changing how VirtualWindowFrame is constructed.

Suggested reviewers

  • lollipopkit
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change by describing the hide-title-bar behavior update and the package/submodule refresh.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hide-titlebar-response

Comment @coderabbitai help to get the list of available commands.

@GT-610 GT-610 changed the title Responsible hide title bar Responsible hide title bar and update packages Jun 27, 2026
@coderabbitai coderabbitai Bot requested a review from lollipopkit June 27, 2026 14:49
@GT-610 GT-610 merged commit 47aef2c into main Jun 27, 2026
3 checks passed
@GT-610 GT-610 deleted the hide-titlebar-response branch June 27, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant