Skip to content

Render MyGo links using the active text flow - #326

Merged
tiensonqin merged 1 commit into
devin/1793834954-text-flow-baselinefrom
devin/1793834954-inline-link-context
Nov 4, 2026
Merged

tiensonqin merged 1 commit into
devin/1793834954-text-flow-baselinefrom
devin/1793834954-inline-link-context

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Select ui.Link(c, "", url) when the actual SDK build parent is text (Context.InTextFlow()), including registered extension text hosts; otherwise preserve standalone LinkBase row/column/icon layout. Keep label/children callbacks, native URL activation and adapter event bindings shared. Invalid non-text children still fail strictly, not flattened or dropped.

Pin published SDK v0.0.0-20261104233121-982f5a6791f0 from logseq/mygo#17 and document the downstream root-module replacement (dependency replacements do not propagate). No portable constructor, wire-schema, App pin, dune or other-host changes.

Actual production baseline: fcff1ec9410bc1b8885d31cd81e92c31569b01c3. Its old target branch was deleted and current main has different ancestry, so the PR targets a review baseline ref at exact fcff with no new commits. The head contains only this five-file fix, no main upgrade. SDK head similarly contains production efb plus the approved query/docs, not later SDK IME/main work. Neither PR is to be merged in this acceptance task.

Verification

With GOWORK=off CGO_ENABLED=0, remote published SDK and no local module/workspace overrides:

  • RED: the single retained Backend.View/ui.Tester regression reproduces original LinkBase -> coreRow -> kindText panic on the old adapter.
  • GREEN: direct Text and extension-created Text hosts, rich text children and one URL activation; existing standalone icon/link regression passes.
  • PASS (complete Git checkout): go test ./... -count=1 (8.872s), go vet ./..., Darwin/Linux/Windows go build ./..., go mod verify, gofmt and diff checks.
  • PASS (remote published LUI module zip): both link regressions, readonly vet, module verification and command compilation. Its binary embeds SDK replace 982f5a6791f0.
  • Full module-zip tests are not claimed: existing TestAllSupportedKindsRender needs repository-external ../../schema/mygo-manifest.json, absent from the Go submodule zip. The same test passes in the complete Git checkout; no fixture workaround added.
  • Remote Origin hashes: LUI 9c3d93b79ef03fc3644d3bcb77d16f03f8f950b1; SDK 982f5a6791f08ef2d447e0f1780fc7e304ebc277.

No live Native Help acceptance claimed. Parent owns final App pins and installed/loaded provenance before GUI testing. SDK-wide locale and Windows WebView E2E baseline failures are evidenced in its PR; do not interpret green adapter checks as all SDK tests passing.

AI disclosure

  • Tool: Devin (Cognition AI; exact underlying model/version not exposed).
  • Used for implementation, regression, documentation and verification.
  • A human read every line of this change and can explain it.

Link to Devin session: https://app.devin.ai/sessions/30b910deab82425bb2b74fd31a87e8c6
Open in Devin Desktop: https://app.devin.ai/desktop/session/30b910deab82425bb2b74fd31a87e8c6?variant=devin
Requested by: @tiensonqin

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@tiensonqin
tiensonqin merged commit 148c2e0 into devin/1793834954-text-flow-baseline Nov 4, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant