Repository navigation
Render MyGo links using the active text flow - #326
Merged
tiensonqin merged 1 commit intoNov 4, 2026
Merged
tiensonqin merged 1 commit into
tiensonqin merged 1 commit into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
1 of 6 tasks
tiensonqin
merged commit Nov 4, 2026
148c2e0
into
devin/1793834954-text-flow-baseline
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Select
ui.Link(c, "", url)when the actual SDK build parent is text (Context.InTextFlow()), including registered extension text hosts; otherwise preserve standaloneLinkBaserow/column/icon layout. Keep label/children callbacks, native URL activation and adapter event bindings shared. Invalid non-text children still fail strictly, not flattened or dropped.Pin published SDK
v0.0.0-20261104233121-982f5a6791f0from logseq/mygo#17 and document the downstream root-module replacement (dependency replacements do not propagate). No portable constructor, wire-schema, App pin, dune or other-host changes.Actual production baseline:
fcff1ec9410bc1b8885d31cd81e92c31569b01c3. Its old target branch was deleted and current main has different ancestry, so the PR targets a review baseline ref at exact fcff with no new commits. The head contains only this five-file fix, no main upgrade. SDK head similarly contains production efb plus the approved query/docs, not later SDK IME/main work. Neither PR is to be merged in this acceptance task.Verification
With
GOWORK=off CGO_ENABLED=0, remote published SDK and no local module/workspace overrides:LinkBase -> coreRow -> kindTextpanic on the old adapter.go test ./... -count=1(8.872s),go vet ./..., Darwin/Linux/Windowsgo build ./...,go mod verify, gofmt and diff checks.982f5a6791f0.../../schema/mygo-manifest.json, absent from the Go submodule zip. The same test passes in the complete Git checkout; no fixture workaround added.9c3d93b79ef03fc3644d3bcb77d16f03f8f950b1; SDK982f5a6791f08ef2d447e0f1780fc7e304ebc277.No live Native Help acceptance claimed. Parent owns final App pins and installed/loaded provenance before GUI testing. SDK-wide locale and Windows WebView E2E baseline failures are evidenced in its PR; do not interpret green adapter checks as all SDK tests passing.
AI disclosure
Link to Devin session: https://app.devin.ai/sessions/30b910deab82425bb2b74fd31a87e8c6
Open in Devin Desktop: https://app.devin.ai/desktop/session/30b910deab82425bb2b74fd31a87e8c6?variant=devin
Requested by: @tiensonqin