Repository navigation
Use SF Symbols for Timeline pull-to-sync stages - #119
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Timeline pull-stage text with
arrow.downbefore the threshold andarrow.clockwisewhen ready to release. Both use the existing footnote size, secondary tint and a fixed 24-point overlay; English accessibility labels remain “Pull to sync” / “Release to sync”. Gesture thresholds, sync events and shared reconnect/pull owners are unchanged; sync activity still uses only the existing spinner beside Options.Validation: fresh pure-Swift build of the actual production List/Chrome views in a distinct-bundle synthetic fixture on A135, plus one passing native XCTest using physical drags. Checked below-threshold cancellation, release once, repeated gestures, one existing header spinner, stable row anchor/Options position, both visible symbols and armed English accessibility. The fixture simulates completion and has no account/network; it does not validate live sync or OCaml ABI. Continuous held down-then-up cancellation was not separately exercised. Existing sync recovery (27) and worker-presentation (6) baseline tests also pass; Swift syntax and diff checks pass. No permanent test target added.
Actual native recording:
Journal-pull-stage-icons-native-A135-complete.mp4(50s), Librarylibfile_2f99814ea4e0819199381e08275aa8e9, version 1. The last 3 seconds are a clearly labelled native XCTest final screenshot showing completion; the gesture footage is unchanged. Clearly marked as actual Swift views with simulated UI completion. Protected Journal containers were preserved, original app restored and GUI released.The new decision document validates; repository-wide decision validation still reports five pre-existing unrelated document errors.