feat: add chat-cli /add with fast group-commit timing - #208
Open
mchenani wants to merge 1 commit into
Open
Conversation
jazzz
approved these changes
Aug 13, 2026
jazzz
left a comment
jazzz
left a comment
Collaborator
There was a problem hiding this comment.
Adjusting the DeMLS timers can be tempting however can due more harm than good.
My preference is that developers do not have access to these values in the future given the complexity involved.
the proposed timers would support ~2-3 members IIRC.
As a living example for how developers use the library, I would lean towards simplicity and clarity and focus on fixing the problem at the root (in DeMLS)
Comment on lines
+362
to
+364
| let chat_id = self.state.active_chat.clone().ok_or_else(|| { | ||
| anyhow::anyhow!("No active conversation. Use /new to create a group.") | ||
| })?; |
Collaborator
There was a problem hiding this comment.
[Sand] Ownership does not appear to be require for chat_id. Use as_ref instead to avoid the copy
Comment on lines
+37
to
+41
| /// Fast GroupV2 timing so `/add` commits in ~1s instead of ~60s — for local | ||
| /// demos and tests. These are the vetted values from the library's group | ||
| /// tests; they are deliberately aggressive and not appropriate for a | ||
| /// high-latency network (hence `--group-commit auto` keeps defaults there). | ||
| fn fast_group_v2_config() -> GroupV2Config { |
Collaborator
There was a problem hiding this comment.
[!] Lowering timers, limits the number of members. If DeMLS proposals cannot be processed in the time allowed, then a deadlock occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.