Fix lstk logs to properly detect emulators running under custom container names#387
Merged
anisaoshafi merged 3 commits intoJul 17, 2026
Merged
Conversation
anisaoshafi
added
semver: patch
docs: skip
anisaoshafi
marked this pull request as ready for review
July 16, 2026 08:53
tiurin
approved these changes
Jul 17, 2026
Comment on lines
+46
to
+55
| if name == "" { | ||
| sink.Emit(output.ErrorEvent{ | ||
| Title: fmt.Sprintf("%s is not running", c.DisplayName()), | ||
| Actions: []output.ErrorAction{ | ||
| {Label: "Start LocalStack:", Value: "lstk"}, | ||
| {Label: "See help:", Value: "lstk -h"}, | ||
| }, | ||
| }) | ||
| return output.NewSilentError(fmt.Errorf("%s is not running", c.Name())) | ||
| } |
Contributor
There was a problem hiding this comment.
question: this is the 4th copy of this code, the first three are in aws.go, az.go and status.go. Maybe we can extract it to a handleNoRunningContainer in, let's say, running.go?
anisaoshafi
enabled auto-merge (squash)
July 17, 2026 16:38
anisaoshafi
deleted the
devx-998-use-resolved-container-lookup-in-lstk-logs
branch
July 17, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lstk logsdidn't detect externally named containers.logs should use the same container resolution logic as the other commands. That would make the behavior consistent across lstk.
Integration test failed and worked after fix.