Repository navigation
Fix the shutdown hook and add CI for both examples - #3
Merged
Merged
Conversation
Fix the shutdown hook and add CI for both examples Claude-Session: https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM
Current images do not pass AWS settings to init scripts, so the aws CLI failed with 'You must specify a region' and boto3 with 'Unable to locate credentials'. Fail the shell hooks on the first error so a broken hook is not reported as successful. Claude-Session: https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo had no CI, and both examples were broken on current LocalStack images.
Fixes:
us-east-1and thetestcredentials.set -eo pipefail. Before,init-vpc.shwas reported asSUCCESSFULeven when every command failed.localstackCLI at/opt/code/localstack/.venv/bin/localstack, sosave-pod.shnow exports state through the/_localstack/pods/stateendpoint with curl.Tests:
example-localstack-cli/test.shchecksinit-vpc.shsucceeded, theMyVPCVPC exists, and it has 3 isolated subnets.example-docker-compose/test.shchecks the init hooks ran, the secret holdshello-there, and both SSM parameters exist.lstk load ./volume/my-pod.zip.example-localstack-cliand run its test.my-pod.zip, then load it into a fresh LocalStack and check the secret survived.Verified by CI, since the examples bind the same ports as a running LocalStack.
https://claude.ai/code/session_01DZfDmzUBPqNAu3yFKyfCNM