Repository navigation
Verify az and kubectl presence before script execution - #44
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both scripts correctly fail before provisioning when required tools are unavailable and pass Bash syntax validation.
0 open findings
What changed in this PR
Adds fail-fast prerequisite checks for Azure CLI and kubectl before AKS provisioning begins.
Changes:
- Validates both required executables and reports installation guidance.
- Corrects the system-assigned script’s network selection prompt.
| File | Description |
|---|---|
scripts/01-user-assigned-managed-identity.sh |
Adds prerequisite validation. |
scripts/01-system-assigned-managed-identity.sh |
Adds prerequisite validation and corrects the menu heading. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull requests fixes #35 and by verifying
azandkubectlpresence before script execution.Fixes SMF-947
Changes
This pull request adds the following checks at the beginning of the
/scripts/01-system-assigned-managed-identity.shandscripts/01-user-assigned-managed-identity.shscripts: