ci: run checks on the bridge-rebase integration branch#408
Draft
islandbitcoin wants to merge 1 commit into
Draft
ci: run checks on the bridge-rebase integration branch#408islandbitcoin wants to merge 1 commit into
islandbitcoin wants to merge 1 commit into
Conversation
Test/check workflows were filtered to `pull_request: branches: [main]`, so PRs targeting the long-lived `tmp/bridge-rebase-pr-ready` integration branch never triggered CI. Add the integration branch to the pull_request filter on all gating workflows, and add a push trigger on the core build/test/lint workflows (check-code, unit-test, integration-test) so the branch tip is checked as PRs stack onto it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI was never running on the Bridge PR stack. Two causes were found:
actions/permissions → enabled:false) — now re-enabled to "Allow all actions and reusable workflows".pull_request: branches: [main]. That filter matches the PR's base branch, so PRs targetingtmp/bridge-rebase-pr-ready(feat(bridge): withdrawal fee estimates — request/confirm/cancel flow #403, Map IBEX crypto sends as USDT on-chain transactions #405, Normalize Bridge webhook payload envelopes #406, Send Bridge cashout USDT to transfer deposit addresses #407) never trigger CI. This PR fixes JMD support for graphs #2.What
tmp/bridge-rebase-pr-readyto thepull_requestbranch filter on all gating workflows:check-code,unit-test,integration-test,audit,bats,mobile-schema-compatibility,mongodb-migrate,quickstart,spelling. PRs into the integration branch now get the same checks as PRs intomain.pushtrigger ontmp/bridge-rebase-pr-readyto the core build/test/lint workflows (check-code,unit-test,integration-test) so the branch tip stays green as PRs stack onto it.Left intentionally untouched:
codeql-analysis(security scan, runs onmain+ schedule),generate-graphql-docs(deploy on push tomain),graphql-diff(on: [push], already all-branches).Notes
main):pull_requestreads the branch filter from the base branch, so the stacked PRs only pick it up once it's here.tmp/bridge-rebase-pr-readyeventually merges tomainand is deleted, remove these temporary branch references from the workflows.pushtrigger could be trimmed if Actions minutes are a concern — say the word.🤖 Generated with Claude Code