fix(dev): update local dev setup for ibex-client v3 OAuth2 auth#375
fix(dev): update local dev setup for ibex-client v3 OAuth2 auth#375forge0x wants to merge 1 commit into
Conversation
- Replace stale IBEX_EMAIL/IBEX_PASSWORD references with IBEX_CLIENT_ID/IBEX_CLIENT_SECRET - Update dev/setup.sh to prompt for OAuth2 client credentials - Update set-overrides.sh to write clientId/clientSecret instead of email/password - Update DEV.md docs to reflect new config format - Remove unused .env IBEX_* vars and update docker-compose env vars
There was a problem hiding this comment.
Pull request overview
This PR updates local development setup for the Ibex OAuth2 client-credentials migration, aligning dev scripts and docs with the app’s existing clientId/clientSecret config shape.
Changes:
- Replaces legacy Ibex email/password prompts and config generation with OAuth2 client credentials.
- Updates local config documentation and sample overrides.
- Updates docker compose and
.envIbex variable names for the price service/local environment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
docker-compose.yml |
Passes IBEX_CLIENT_ID and IBEX_CLIENT_SECRET to the price service. |
dev/setup.sh |
Prompts for OAuth2 credentials and generates local Ibex overrides. |
dev/config/set-overrides.sh |
Updates interactive override prompts for clientId/clientSecret. |
DEV.md |
Documents the new Ibex local override format. |
.env |
Replaces old Ibex env placeholders with OAuth2 credential placeholders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ```bash | ||
| source .env && source .env.local | ||
| ``` | ||
| Flash uses YAML config files. Ibex OAuth2 credentials go in local config overrides, not env vars. |
| export IBEX_CLIENT_ID='${IBEX_CLIENT_ID}' | ||
| export IBEX_CLIENT_SECRET='${IBEX_CLIENT_SECRET}' |
| echo "Checking Ibex credentials..." | ||
|
|
||
| if [ -f .env.local ] && grep -q "IBEX_PASSWORD" .env.local 2>/dev/null; then | ||
| if [ -f .env.local ] && grep -q "IBEX_CLIENT_ID" .env.local 2>/dev/null; then |
bobodread876
left a comment
bobodread876
left a comment
There was a problem hiding this comment.
Dev-setup migration looks complete and consistent with the ibex-client v3 OAuth2 change — setup.sh, set-overrides.sh, DEV.md, .env, and docker-compose.yml all move cleanly to IBEX_CLIENT_ID/IBEX_CLIENT_SECRET.
One gap: .env.ci:74 still has IBEX_PASSWORD=${IBEX_PASSWORD} — CI wasn't migrated alongside the local dev files. Could you either update it to the OAuth2 vars or drop the line if CI no longer needs ibex password auth? Otherwise it's a dead/broken reference left over from the old auth method.
(Minor, no action needed: DEV.md:228 still mentions the harmless IBEX_URL docker-compose warning — accurate as-is.)
The ENG-38 Ibex auth migration replaced email/password login with OAuth2 client credentials (clientId + clientSecret). The dev setup scripts and docs still referenced the old auth method.
Changes:
IBEX_EMAIL/IBEX_PASSWORDprompts withIBEX_CLIENT_ID/IBEX_CLIENT_SECRETindev/setup.shdev/config/set-overrides.shto prompt forclientId/clientSecretinstead ofemail/passwordDEV.mddocs to document the new config formatIBEX_URL/IBEX_EMAIL/IBEX_PASSWORDenv vars in.envanddocker-compose.ymlMultiple devs can share the same sandbox clientId/clientSecret.