[VK] Update format and XFAILs for uint64_t2/int64_t2 typed buffers#1377
Merged
Conversation
kmpeng
added
test-all
kmpeng
force-pushed
the
update-typedbuffer-64bit-vector-tests
branch
from
July 17, 2026 17:39
89b9194 to
58f2771
Compare
bob80905
approved these changes
Jul 17, 2026
inbelic
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After llvm/llvm-project#208626 landed, fixing #1037 on the Clang side, SPIR-V now packs 2-component 64-bit typed buffer elements into 4-component 32-bit images. This PR updates the Vulkan format for those buffers to
R32G32B32A32and updates the 64-bit typed buffer vector test to no longer XFAIL on Clang (still fails on DXC pending microsoft/DirectXShaderCompiler#8615).