Add InterlockedXor tests#1370
Open
bob80905 wants to merge 2 commits into
Open
Conversation
Icohedron
reviewed
Jul 16, 2026
| Format: UInt64 | ||
| Channels: 1 | ||
| FillSize: 32 | ||
| FillValue: 137 # trash non-zero initialization data |
Contributor
There was a problem hiding this comment.
Why does only InterlockedXor.resources.typed.int64.test fill atomic-destination buffers with trash? Should the other InterlockedXor.resources.* tests also fill the atomic-destination buffers with trash?
| // covered here, to keep this test portable across implementations. | ||
| // | ||
| // See InterlockedXor.32.test for a full description of the unique-bit | ||
| // atomicity construction: each destination holds four 64-bit words, thread t |
Contributor
There was a problem hiding this comment.
nit: "each destination holds four 64-bit words" is inaccurate, since BABuf holds 8 64-bit words.
inbelic
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the tests for the InterlockedXor HLSL function.
Adds 32 bit and 64 bit signed/unsigned integer tests, along with some resource member function tests.
Assisted by: Github Copilot
Fixes: #855