Refactor to AST - #197
Draft
ganyicz wants to merge 58 commits into
Draft
Conversation
ganyicz
marked this pull request as draft
August 6, 2026 12:51
Contributor
Benchmark Result: Default
Median of 10 attempts, 5000 iterations x 10 rounds, 47.83s total To run a specific benchmark, comment |
Collaborator
Author
|
/benchmark compilation |
Contributor
Benchmark Result: Compilation
Median of 10 attempts, 5000 iterations x 10 rounds, 2.87s total To run a specific benchmark, comment |
Collaborator
Author
|
/benchmark compilation |
Collaborator
Author
|
/benchmark compilation |
Collaborator
Author
|
/benchmark compilation |
ganyicz
marked this pull request as ready for review
August 9, 2026 21:31
ganyicz
marked this pull request as draft
August 9, 2026 23:29
Collaborator
Author
|
/benchmark compilation |
ganyicz
marked this pull request as ready for review
August 10, 2026 08:29
ganyicz
marked this pull request as draft
August 10, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #193, which adds support for parsing directives, this PR refactors rest of Blaze to take advantage of that:
@propsand@awaredirectives@unblazeblocks@blaze,@propsand@awaredirectives@phpblocks and@usedirectivesPreviously we used
DirectiveCompilerfor this. This class hacked into Laravel'sBladeCompilerto delegate the parsing of directives to Blade, however in #193 we brought most of that logic into our tokenizer and directives are now part of the AST.After this PR, all analysis and compilation is now driven by the AST, including skipping over
<?php,@phpand@verbatimblocks, which was previously also done by hacking intoBladeCompiler.This required bigger structural changes however creates multiple benefits:
BladeCompilerin most placesThe performance improvement is mostly the result of caching the AST and dropping the
DirectiveCompilerwhich used reflection and had to run multiple regexes over the entire template repeatedly.