Skip to content

docs: prompt for forge tests and scope updates in the PR template #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rickstaa wants to merge 1 commit into from
Closed

docs: prompt for forge tests and scope updates in the PR template #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,30 @@
**What does this pull request do? Explain your changes. (required)**
## What does this pull request do? (required)

<!-- A clear and concise description of what this pull request does. -->

**Specific updates (required)**
<!--- List out all significant updates your code introduces -->
## Specific updates (required)

<!-- List out all significant updates your code introduces -->

- ...
- ...
- ...

**How did you test each of these updates (required)**
## How did you test each of these updates? (required)

<!-- A detailed description of how you tested your code changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. -->

## Does this pull request close any open issues?

**Does this pull request close any open issues?**
<!-- Fixes # -->

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

**Checklist:**
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] README and other documentation updated
- [ ] All tests using `yarn test` pass
- [ ] `forge test` passes when `contracts/` or `src/test/` changed. Needs an archive
Arbitrum RPC; paste the summary line, or say why you could not run it.
- [ ] If any deployed address changed, the Immunefi scope page is updated
Loading