Proper setting of client SDK#1081
Merged
Merged
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the signal client’s v1 join-request generation to report the correct SDK identity (and version) in ClientInfo, rather than always reporting Rust, which improves cross-language wrapper attribution while keeping the existing v0 query-param behavior intact.
Changes:
- Added
client_info_sdk_for_name()to map SDK name strings (e.g.,"cpp","C++","react-native") intoproto::client_info::Sdk. - Updated v1
JoinRequestconstruction to setclient_info.sdkbased onSignalOptions.sdk_options.sdk. - Added unit tests covering SDK-name mapping and verifying SDK/version reporting for both v0 URL params and v1 join_request payload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ladvoc
approved these changes
May 11, 2026
ladvoc
approved these changes
May 11, 2026
xianshijing-lk
approved these changes
May 11, 2026
Contributor
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
some comments, lgtm after addressing them
stephen-derosa
force-pushed
the
sderosa/BOT-348-ffi-lib-reporting
branch
from
7f1c302 to
2389266
Compare
stephen-derosa
changed the title
stephen-derosa
force-pushed
the
sderosa/BOT-348-ffi-lib-reporting
branch
from
5b4674e to
8d90884
Compare
stephen-derosa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Report the corect client fclient_info_sdk_for_name
Breaking changes
I dont believe there are breaking changes
Testing
Unit tests inline