feat: auto failover APIs with LK Cloud#733
Open
davidzhao wants to merge 1 commit into
Open
Conversation
retries in alternative datacenters on 5xx and transport failures
davidzhao
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
theomonnom
approved these changes
Jun 27, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
theomonnom
reviewed
Jun 27, 2026
| host: str, | ||
| pkg: str, | ||
| prefix: str = DEFAULT_PREFIX, | ||
| failover: Optional[FailoverConfig] = None, |
Member
There was a problem hiding this comment.
nit: FailoverOptions for consistency with agents
Member
|
Should we fail fast with a shorter timeout? |
theomonnom
reviewed
Jun 27, 2026
| error_data = {} | ||
| if resp.status < 500: | ||
| # 4xx is terminal. | ||
| raise self._twirp_error(error_data, resp.status) |
Member
There was a problem hiding this comment.
Should we log a warning on retry?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retries in alternative datacenters on 5xx and transport failures