-
Notifications
You must be signed in to change notification settings - Fork 63
Restore cached iOS audio session on PlatformAudio dispose #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxHeimbrock
wants to merge
1
commit into
main
Choose a base branch
from
max/ios-restore-audio-session
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,6 +74,11 @@ public sealed class PlatformAudio : IDisposable | |
| internal readonly FfiHandle Handle; | ||
| private readonly PlatformAudioInfo _info; | ||
| private bool _disposed = false; | ||
| #if UNITY_IOS && !UNITY_EDITOR | ||
| // Tracks live PlatformAudio instances so the iOS audio session is restored | ||
| // only when the last one is disposed (aligned with the native ADM ref-count). | ||
| private static int _instanceCount; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit, initialize it to 0 as default value ? |
||
| #endif | ||
|
|
||
| /// <summary> | ||
| /// Number of available recording (microphone) devices. | ||
|
|
@@ -119,6 +124,12 @@ public PlatformAudio() | |
| _info = platformAudio.Info; | ||
|
|
||
| Utils.Debug($"PlatformAudio created: {RecordingDeviceCount} recording devices, {PlayoutDeviceCount} playout devices"); | ||
|
|
||
| #if UNITY_IOS && !UNITY_EDITOR | ||
| // Count this instance only after successful construction so a failed | ||
| // ctor never leaves the counter stuck above zero. | ||
| System.Threading.Interlocked.Increment(ref _instanceCount); | ||
| #endif | ||
| } | ||
|
|
||
| /// <summary> | ||
|
|
@@ -365,6 +376,14 @@ public void Dispose() | |
| if (_disposed) return; | ||
| Handle.Dispose(); | ||
| _disposed = true; | ||
|
|
||
| #if UNITY_IOS && !UNITY_EDITOR | ||
| // Restore the audio session Unity had before VoIP, but only once the | ||
| // last PlatformAudio is gone (the native ADM is likewise ref-counted). | ||
| if (System.Threading.Interlocked.Decrement(ref _instanceCount) == 0) | ||
| IOSAudioSessionHelper.LiveKit_RestoreDefaultAudioSession(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit, add a {} for style |
||
| #endif | ||
|
|
||
| Utils.Debug("PlatformAudio disposed"); | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curiously, should we continue caching the latest session rather than simply return here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this is supposed to be a draft, not ready for review. We have some issues with teardown but this one does not solve it all, I am still investigating.