Skip to content

Add deployment to TokenSourceFetch options#1971

Open
lukasIO wants to merge 4 commits into
mainfrom
lukas/agent-deployment
Open

Add deployment to TokenSourceFetch options#1971
lukasIO wants to merge 4 commits into
mainfrom
lukas/agent-deployment

Conversation

@lukasIO

@lukasIO lukasIO commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 26914fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@1egoman

1egoman commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I am a bit confused by the typescript failure in ci: Error: src/room/token-source/utils.ts(67,15): error TS2322: Type '"deployment"' is not assignable to type 'never'. - is this using the right @livekit/protocol version? That line number makes no sense for this error though...

@1egoman

1egoman commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

You may or may not be aware but for this to propagate to useSession in components-js properly, there's a bit of technical debt that needs to be cleaned up which I keep forgetting to address.

Comment on lines 65 to 67
agentMetadata?: string;
deployment?: string;
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the equivalent to metadata there is the agentMetadata we set explicitly here as well, I believe?

I don't think we have another option to set this as part of RoomConfig ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on metadata, yes good point.

Does restartPolicy need to be able to be set in here too? As of now, in the node version, I think it is settable so assuming it isn't server specific, it maybe needs to be able to be configured here as well?

@lukasIO

lukasIO commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

I am a bit confused by the typescript failure in ci: Error: src/room/token-source/utils.ts(67,15): error TS2322: Type '"deployment"' is not assignable to type 'never'. - is this using the right @livekit/protocol version? That line number makes no sense for this error though...

there were two equality checks (one in TokenSource and one in utils) and I forgot about the one in utils.
I've now simply replaced the other one with the one from utils.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 100.49 KB (0%)
dist/livekit-client.umd.js 109.45 KB (-0.11% 🔽)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants