Add deployment to TokenSourceFetch options#1971
Conversation
🦋 Changeset detectedLatest commit: 26914fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I am a bit confused by the typescript failure in ci: |
|
You may or may not be aware but for this to propagate to |
| agentMetadata?: string; | ||
| deployment?: string; | ||
| }; |
There was a problem hiding this comment.
thought: Does this CreateDispatchOptions data need to be included in here as well?
There was a problem hiding this comment.
the equivalent to metadata there is the agentMetadata we set explicitly here as well, I believe?
I don't think we have another option to set this as part of RoomConfig ?
There was a problem hiding this comment.
👍 on metadata, yes good point.
Does restartPolicy need to be able to be set in here too? As of now, in the node version, I think it is settable so assuming it isn't server specific, it maybe needs to be able to be configured here as well?
there were two equality checks (one in TokenSource and one in utils) and I forgot about the one in utils. |
size-limit report 📦
|
No description provided.