Skip to content

Fix publish workflow failing on the flutter_webrtc pin warning - #1140

Open
hiroshihorie wants to merge 2 commits into
mainfrom
hiroshi/fix-publish-workflow
Open

Fix publish workflow failing on the flutter_webrtc pin warning#1140
hiroshihorie wants to merge 2 commits into
mainfrom
hiroshi/fix-publish-workflow

Conversation

@hiroshihorie

Copy link
Copy Markdown
Member

Every publish workflow run in this repo's history has failed with exit code 65. The dart-lang reusable publish workflow runs a non-interactive dart pub publish, which treats any validation warning as fatal. Our exact flutter_webrtc pin is intentional (the native WebRTC-SDK pods must match between the two packages) but always produces the 'should allow more than one version' warning, so the workflow can never succeed and every release so far has been published manually.

This replaces the reusable workflow with an inline job that publishes with --force, which downgrades warnings to informational. dart-lang/setup-dart is kept solely for pub.dev auth: with id-token: write it mints a temporary pub.dev token from the GitHub OIDC token and registers it in the shared pub config, which the Flutter-side dart pub publish then picks up. The pub.dev trust configuration is based on repository and tag claims, not the workflow definition, so no changes are needed on the pub.dev side.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@github-actions

Copy link
Copy Markdown

Warning

No changeset found

If this PR includes user-facing changes, please add a changeset file in .changes/

Format: level type="kind" "description"

patch type="fixed" "Fix audio frame generation"
minor type="added" "Add support for custom audio processing"
major type="changed" "Breaking: Rename Room.connect() to Room.join()"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants