Remove non-public buttonPressed: selector from broadcast picker activation - #1138
Open
hiroshihorie wants to merge 1 commit into
Open
Remove non-public buttonPressed: selector from broadcast picker activation#1138hiroshihorie wants to merge 1 commit into
hiroshihorie wants to merge 1 commit into
Conversation
…ation Apple's automated App Review flags the literal buttonPressed: selector string in application binaries (ITMS-90338 / Guideline 2.5.1), blocking submissions for any app that includes the plugin, even without using screen sharing. Replace the private-selector invocation with public API: locate the picker's UIButton subview and fire it via sendActions(for:).
hiroshihorie
marked this pull request as ready for review
July 27, 2026 19:18
hiroshihorie
requested review from
cloudwebrtc and
xianshijing-lk
as code owners
July 27, 2026 19:18
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apple's automated App Review flags the literal
buttonPressed:selector string in application binaries (ITMS-90338 / Guideline 2.5.1) and blocks App Store submissions. Since the plugin compilesios/Classes/**into every app, any iOS app usinglivekit_clientis exposed — even if it never uses screen sharing or ReplayKit.BroadcastManager.showPicker(for:)constructed and performed the private selector to programmatically activate the system broadcast picker (reached viasetScreenShare→broadcastRequestActivationmethod channel). It now activates the picker using only public API: locate the picker'sUIButtonsubview and fire it viasendActions(for: .touchUpInside). If the button is ever not found (e.g. a future OS changes the view hierarchy), a warning is logged instead of silently no-opping.No API changes; runtime behavior is identical.
Verification
rg buttonPressed ios/ macos/returns no matches, so the selector string no longer reaches downstream binariesswiftc -typecheckagainst the iOS simulator SDK passes for the changed file and its dependencies