Use maintain-resolution as the default video degradation preference#1106
Merged
Conversation
|
Caution Breaking change detected without major changeset
If this is intentional, please add a changeset with |
There was a problem hiding this comment.
Pull request overview
This PR updates the Flutter SDK’s default local-video degradation behavior to match the Swift SDK by defaulting to DegradationPreference.maintainResolution when apps do not explicitly set VideoPublishOptions.degradationPreference, for both camera and screen-share video publishing.
Changes:
- Default unset
VideoPublishOptions.degradationPreferencetoDegradationPreference.maintainResolutionwhen publishing camera or screen-share video tracks. - Remove the prior resolution/source-based defaulting helper (
getDefaultDegradationPreference) since the default is now unconditional. - Add a patch-level changeset documenting the behavior change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/src/participant/local.dart | Defaults local video publishing degradation preference to maintainResolution when unset and removes the previous conditional default helper. |
| .changes/video-degradation-default | Adds a patch changeset entry describing the new default behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VideoPublishOptions.degradationPreferencetomaintainResolutionfor camera and screen-share publishing.Context
Related to #1097, which explores preserving video quality through a live-streaming option. This PR takes the smaller SDK-default approach instead: use maintain-resolution by default, matching Swift, without adding a separate app-facing toggle for this behavior.
Testing
dart analyzeflutter test test/core/room_e2e_test.dart