-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(plugins-tavus): rename replica/persona to face/pal #6239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carolin-tavus
wants to merge
7
commits into
livekit:main
Choose a base branch
from
carolin-tavus:feat/tavus-face-pal-rename
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+252
−22
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e04a4cf
feat(plugins-tavus): rename replica/persona to face/pal
carolin-tavus 1715ff7
test(plugins-tavus): cover face/pal rename and deprecated aliases
carolin-tavus 62ad7c8
feat(plugins-tavus): send face_id/pal_id on the wire, add create_pal
carolin-tavus 38e27f4
fix(plugins-tavus): allow pal_id without face_id
carolin-tavus 643b8a2
feat(plugins-tavus): default to a stock face when none provided
carolin-tavus d0ec2fb
Apply suggestion from @devin-ai-integration[bot]
tinalenguyen 656ce8f
fix(plugins-tavus): only warn on a deprecated alias when it's actuall…
carolin-tavus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 144 additions & 0 deletions
144
livekit-plugins/livekit-plugins-tavus/tests/test_tavus.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| import warnings | ||
|
tinalenguyen marked this conversation as resolved.
|
||
| from unittest.mock import AsyncMock, patch | ||
|
|
||
| import pytest | ||
|
|
||
| from livekit.agents.utils import http_context | ||
| from livekit.plugins.tavus.api import DEFAULT_FACE_ID, TavusAPI | ||
| from livekit.plugins.tavus.avatar import AvatarSession | ||
|
|
||
| pytestmark = pytest.mark.unit | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def _env(monkeypatch): | ||
| for v in ("TAVUS_FACE_ID", "TAVUS_PAL_ID", "TAVUS_REPLICA_ID", "TAVUS_PERSONA_ID"): | ||
| monkeypatch.delenv(v, raising=False) | ||
| monkeypatch.setenv("TAVUS_API_KEY", "test-key") | ||
|
|
||
|
|
||
| def _api() -> TavusAPI: | ||
| # session is unused because _post is always mocked in these tests | ||
| return TavusAPI(session=object()) # type: ignore[arg-type] | ||
|
|
||
|
|
||
| def _mock_post() -> AsyncMock: | ||
| return AsyncMock(return_value={"conversation_id": "conv1", "persona_id": "pal_auto"}) | ||
|
|
||
|
|
||
| def _no_deprecation(rec: list[warnings.WarningMessage]) -> bool: | ||
| return not [w for w in rec if issubclass(w.category, DeprecationWarning)] | ||
|
|
||
|
|
||
| async def test_new_args_map_to_unchanged_wire_keys(): | ||
| api = _api() | ||
| with patch.object(api, "_post", new=_mock_post()) as m: | ||
| with warnings.catch_warnings(record=True) as rec: | ||
| warnings.simplefilter("always") | ||
| cid = await api.create_conversation(face_id="f1", pal_id="p1") | ||
| assert cid == "conv1" | ||
| payload = m.call_args.args[1] | ||
| assert payload["face_id"] == "f1" | ||
| assert payload["pal_id"] == "p1" | ||
| assert _no_deprecation(rec) | ||
|
|
||
|
|
||
| async def test_deprecated_args_still_work_and_warn(): | ||
| api = _api() | ||
| with patch.object(api, "_post", new=_mock_post()) as m: | ||
| with pytest.warns(DeprecationWarning) as rec: | ||
| await api.create_conversation(replica_id="r1", persona_id="x1") | ||
| payload = m.call_args.args[1] | ||
| assert payload["face_id"] == "r1" | ||
| assert payload["pal_id"] == "x1" | ||
| msgs = [str(w.message) for w in rec] | ||
| assert any("replica_id" in s and "face_id" in s for s in msgs) | ||
| assert any("persona_id" in s and "pal_id" in s for s in msgs) | ||
|
|
||
|
|
||
| async def test_no_warning_when_new_and_deprecated_both_given(): | ||
| api = _api() | ||
| with patch.object(api, "_post", new=_mock_post()) as m: | ||
| with warnings.catch_warnings(record=True) as rec: | ||
| warnings.simplefilter("always") | ||
| await api.create_conversation( | ||
| face_id="f1", replica_id="r1", pal_id="p1", persona_id="x1" | ||
| ) | ||
| # the new values win, so the deprecated aliases are unused -> no warning | ||
| assert _no_deprecation(rec) | ||
| payload = m.call_args.args[1] | ||
| assert payload["face_id"] == "f1" | ||
| assert payload["pal_id"] == "p1" | ||
|
|
||
|
|
||
| async def test_new_env_vars_fallback(monkeypatch): | ||
| monkeypatch.setenv("TAVUS_FACE_ID", "envf") | ||
| monkeypatch.setenv("TAVUS_PAL_ID", "envp") | ||
| api = _api() | ||
| with patch.object(api, "_post", new=_mock_post()) as m: | ||
| with warnings.catch_warnings(record=True) as rec: | ||
| warnings.simplefilter("always") | ||
| await api.create_conversation() | ||
| payload = m.call_args.args[1] | ||
| assert payload["face_id"] == "envf" | ||
| assert payload["pal_id"] == "envp" | ||
| assert _no_deprecation(rec) | ||
|
|
||
|
|
||
| async def test_deprecated_env_vars_still_work_and_warn(monkeypatch): | ||
| monkeypatch.setenv("TAVUS_REPLICA_ID", "oldf") | ||
| monkeypatch.setenv("TAVUS_PERSONA_ID", "oldp") | ||
| api = _api() | ||
| with patch.object(api, "_post", new=_mock_post()) as m: | ||
| with pytest.warns(DeprecationWarning): | ||
| await api.create_conversation() | ||
| payload = m.call_args.args[1] | ||
| assert payload["face_id"] == "oldf" | ||
| assert payload["pal_id"] == "oldp" | ||
|
|
||
|
|
||
| async def test_auto_creates_pal_when_none_given(): | ||
| api = _api() | ||
| post = AsyncMock(side_effect=[{"pal_id": "pal_new"}, {"conversation_id": "conv1"}]) | ||
| with patch.object(api, "_post", new=post): | ||
| await api.create_conversation(face_id="f1") | ||
| pal_endpoint, pal_payload = post.call_args_list[0].args | ||
| conv_endpoint, conv_payload = post.call_args_list[1].args | ||
| assert pal_endpoint == "pals" | ||
| assert pal_payload["default_face_id"] == "f1" | ||
| assert conv_endpoint == "conversations" | ||
| assert conv_payload["face_id"] == "f1" | ||
| assert conv_payload["pal_id"] == "pal_new" | ||
|
|
||
|
|
||
| async def test_pal_id_only_skips_pal_creation_and_omits_face(): | ||
| api = _api() | ||
| with patch.object(api, "_post", new=_mock_post()) as m: | ||
| await api.create_conversation(pal_id="p1") | ||
| endpoints = [c.args[0] for c in m.call_args_list] | ||
| assert "pals" not in endpoints # an existing pal carries its own default face | ||
| payload = m.call_args.args[1] | ||
| assert payload["pal_id"] == "p1" | ||
| assert "face_id" not in payload | ||
|
|
||
|
|
||
| async def test_defaults_face_when_neither_given(): | ||
| api = _api() | ||
| post = AsyncMock(side_effect=[{"pal_id": "pal_new"}, {"conversation_id": "conv1"}]) | ||
| with patch.object(api, "_post", new=post): | ||
| await api.create_conversation() | ||
| pal_endpoint, pal_payload = post.call_args_list[0].args | ||
| assert pal_endpoint == "pals" | ||
| assert pal_payload["default_face_id"] == DEFAULT_FACE_ID | ||
|
|
||
|
|
||
| async def test_avatar_session_resolves_new_and_deprecated_args(): | ||
| async with http_context.open(): | ||
| with pytest.warns(DeprecationWarning): | ||
| deprecated = AvatarSession(replica_id="r9", persona_id="x9") | ||
| assert deprecated._face_id == "r9" | ||
| assert deprecated._pal_id == "x9" | ||
|
|
||
| renamed = AvatarSession(face_id="f9", pal_id="p9") | ||
| assert renamed._face_id == "f9" | ||
| assert renamed._pal_id == "p9" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Behavioral change: missing face/pal no longer raises an exception
Previously, if no
replica_idwas provided (via argument or env var),create_conversationraisedTavusException("TAVUS_REPLICA_ID must be set"). Now, if neitherface_idnorpal_idis provided, the code silently auto-creates a pal usingDEFAULT_FACE_ID = "r72f7f7f7c8b"(livekit-plugins/livekit-plugins-tavus/livekit/plugins/tavus/api.py:27). This is a deliberate UX improvement (zero-config start), but existing users who relied on the error to catch missing configuration will no longer get that safety net. The default face ID is hardcoded; if it becomes invalid on the Tavus side, the API call will fail with a less clear error from the Tavus API rather than a local validation error.Was this helpful? React with 👍 or 👎 to provide feedback.