Security: replace IPC pickle with JSON to prevent RCE#5592
Open
johnpippett wants to merge 1 commit intolivekit:mainfrom
Open
Security: replace IPC pickle with JSON to prevent RCE#5592johnpippett wants to merge 1 commit intolivekit:mainfrom
johnpippett wants to merge 1 commit intolivekit:mainfrom
Conversation
Replaces pickle.loads/pickle.dumps with json + logging.makeLogRecord in LogQueueListener and LogQueueHandler. This eliminates arbitrary code execution via malicious IPC log payloads while preserving full LogRecord fidelity. Fixes: IPC pickle.loads RCE (Critical) Refs: livekit-agents/livekit/agents/ipc/log_queue.py:62
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a critical IPC pickle.loads RCE (CWE-502).
All IPC tests pass (8/8).