(examples revamp): remove redundant files#5523
Open
tinalenguyen wants to merge 5 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
🐛 1 issue in files not directly in the diff
🐛 Missing follow_redirects=True in streamable HTTP client causes redirect failures (livekit-agents/livekit/agents/llm/mcp.py:309-312)
The old _create_http_client method (removed in this PR) explicitly set follow_redirects=True when creating the httpx.AsyncClient. The new inline client creation at livekit-agents/livekit/agents/llm/mcp.py:309 omits this parameter, and httpx.AsyncClient defaults to follow_redirects=False. This means any MCP server behind a redirect (common for auth flows, load balancers, CDNs) will fail with the streamable HTTP transport. The old factory was documented as "ported from mcp.shared._httpx_utils.create_mcp_http_client", suggesting redirect support is expected behavior for MCP clients.
View 7 additional findings in Devin Review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these examples will be removed because they are already present in another example or are already in the docs:
./avatar_agents./other/text-to-speechbackground_audio.pyemail_example.pyGetEmailTask()nvidia_test.pybasic_agent.pyrealtime_video_agent.pyrealtime_with_tts.pyweb_search.pysilent_function_call.pyphonic_realtime_agent.pymulti_agent.pyrealtime_turn_detector.pysession_close_callback.pyresume_interrupted_agent.pyrealtime_load_chat_history.pyannotated_tool_args.pytimed_agent_transcript.pyspeedup_output_audio.pyultravox_realtime_api.pydynamic_tool_creation.pyzapier_mcp_integration.pyweather_agent.pybasic_agent.pystructured_output.pytoggle_io.pyspeaker_id_multi_speaker.pyraw_function_description.pyinactive_user.pylanggraph_agent.pylong_running_function.pyminimal_worker.pyelevenlab_scribe_v2.pykokoro_tts.pyopenai.TTS.with_kokoro()?legacy_api.pyvideo-publisher.pytranslator.pyflush_llm_node.pytext_only.pytranscriber.pyparticipant_entrypoint.pye2ee.pyrealtime_joke_teller.pypush_to_talk.pyasync_tool_agent.pyfast-preresponse.pyerror_callback.pylangfuse_trace.pyinstructions_per_modality.pyrestaurant.pytool_search_agent.py