Conversation
pblazej
reviewed
May 4, 2026
| } | ||
| } | ||
| #if os(iOS) | ||
| .listSectionSpacing(24) |
Contributor
There was a problem hiding this comment.
This line won't build on iOS (newer SwiftUI API), feel free to drop it.
pblazej
reviewed
May 4, 2026
| @ViewBuilder | ||
| private var payloadSection: some View { | ||
| Section { | ||
| TextEditor(text: $payload) |
Contributor
There was a problem hiding this comment.
This layout will probably break on iOS for bigger payloads, I'd do "predefined payload list" + field instead.
pblazej
reviewed
May 4, 2026
Contributor
pblazej
left a comment
pblazej
left a comment
There was a problem hiding this comment.
Nothing wrong with the UI per se (this example needs a more consistent architecture anyway), maybe it would be more useful with the ability to register the method on the other end?
pblazej
reviewed
May 4, 2026
| isSending = true | ||
| let started = Date() | ||
|
|
||
| Task { @MainActor in |
Contributor
There was a problem hiding this comment.
Nit: you don't need this main actor
Contributor
|
Btw: you can pull https://skills.sh/avdlee/swiftui-agent-skill/swiftui-expert-skill if you wanna dig deeper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a rpc testing interface into the swift example to make exercising RPC use cases easier.
Here's a screenshot of roughly what it looks like:
Warning
This pull request was LLM generated and has only been lightly reviewed by a human. The author has tested this and confirms it works in the happy path, but no other validation has been done.
A more thorough review from a swift expert this needs to occur before this could be merged.