Draft
Fix three review comments from PR #72: smoke matrix, pg_regress artifact paths, DROP IF EXISTS#73
Conversation
…in pg_regress, add IF EXISTS to DROP FOREIGN TABLE
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix three review comments from PR #72: smoke matrix, pg_regress artifact paths, DROP IF EXISTS
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses three review issues flagged on PR #72 (container-based build + pg_regress tests), and carries all of that PR's changes forward.
Review fixes
1. Remove
table_type: externalsmoke-test matrix entries (smoke-tests.yml)ci/build-tea.shnow builds with-DTEA_BUILD_EXT=OFF, so the external-table protocol is not installed in the runtime artifact. The twotable_type: externalmatrix entries would reliably fail; removed them.2. Fix
cp --parentsreceiving absolute paths (ci/run-pg-regress.sh)3.
DROP FOREIGN TABLE IF EXISTS(extension/sql/tea_extension.sql)Changed the cleanup statement to
DROP FOREIGN TABLE IF EXISTS tea_fdw_empty_probeso a rerun after a mid-test failure doesn't obscure the real error with a "table does not exist" noise failure. Expected output updated accordingly.PR #72 changes included
CMakeLists.txt/tea/gpext/CMakeLists.txt/extension/CMakeLists.txt: newTEA_BUILD_EXTCMake option; ext-table sources and SQL generation guarded behind itci/build-tea.sh: arrow-thirdparty cache warm-up;-DTEA_BUILD_EXT=OFFci/build-gpdb.sh: drop stalerm -rf gpdbci/run-pg-regress.sh: new script — stages tea undergpcontrib/, runsmake installcheck, collects resultsextension/Makefile,extension/sql/tea_extension.sql,extension/expected/tea_extension.out: PGXS harness + regress test verifying FDW works and ext-table creation fails as expected whenTEA_BUILD_EXT=OFFghcr.io/lithium-tech/tea-build), structured logging/artifact uploads, concurrency controls, CI report job