Skip to content

Fix three review comments from PR #72: smoke matrix, pg_regress artifact paths, DROP IF EXISTS#73

Draft
leborchuk with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-comments-in-review-thread
Draft

Fix three review comments from PR #72: smoke matrix, pg_regress artifact paths, DROP IF EXISTS#73
leborchuk with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-comments-in-review-thread

Conversation

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown

Addresses three review issues flagged on PR #72 (container-based build + pg_regress tests), and carries all of that PR's changes forward.

Review fixes

1. Remove table_type: external smoke-test matrix entries (smoke-tests.yml)

ci/build-tea.sh now builds with -DTEA_BUILD_EXT=OFF, so the external-table protocol is not installed in the runtime artifact. The two table_type: external matrix entries would reliably fail; removed them.

2. Fix cp --parents receiving absolute paths (ci/run-pg-regress.sh)

# Before – copies into ${results_dir}/home/gpadmin/... deep hierarchy
find "${extension_dir}" -type f ... -exec cp --parents '{}' "${results_dir}/" \;

# After – relative paths keep artifact layout flat
( cd "${extension_dir}" && \
  find . -type f ... -exec cp --parents '{}' "${results_dir}/" \; ) || true

3. DROP FOREIGN TABLE IF EXISTS (extension/sql/tea_extension.sql)

Changed the cleanup statement to DROP FOREIGN TABLE IF EXISTS tea_fdw_empty_probe so a rerun after a mid-test failure doesn't obscure the real error with a "table does not exist" noise failure. Expected output updated accordingly.

PR #72 changes included

  • CMakeLists.txt / tea/gpext/CMakeLists.txt / extension/CMakeLists.txt: new TEA_BUILD_EXT CMake option; ext-table sources and SQL generation guarded behind it
  • ci/build-tea.sh: arrow-thirdparty cache warm-up; -DTEA_BUILD_EXT=OFF
  • ci/build-gpdb.sh: drop stale rm -rf gpdb
  • ci/run-pg-regress.sh: new script — stages tea under gpcontrib/, runs make installcheck, collects results
  • extension/Makefile, extension/sql/tea_extension.sql, extension/expected/tea_extension.out: PGXS harness + regress test verifying FDW works and ext-table creation fails as expected when TEA_BUILD_EXT=OFF
  • Workflow files: container-based execution (ghcr.io/lithium-tech/tea-build), structured logging/artifact uploads, concurrency controls, CI report job

…in pg_regress, add IF EXISTS to DROP FOREIGN TABLE
Copilot AI changed the title [WIP] Fix code based on review comments Fix three review comments from PR #72: smoke matrix, pg_regress artifact paths, DROP IF EXISTS Jul 24, 2026
Copilot AI requested a review from leborchuk July 24, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants