Add FDW server options support - #71
Merged
Merged
Conversation
Add possibility to configure TEA using SQL and don't use tea-config.json. Settings can be got from FDW server options. When there is no read_config_file=false in FDW server options, setting are read from tea-config.json. Not all settings are supported now. Other settings will be added in the future. Add the StrToCatalogType function, because now string casting to CatalogType is executed in two functions.
gmusya
requested changes
Jul 29, 2026
Comment on lines
+554
to
+555
| LoadStr(config.catalog.rest_url, "catalog_rest_url"); | ||
| LoadStr(config.catalog.rest_warehouse_id, "catalog_rest_warehouse_id"); |
Contributor
There was a problem hiding this comment.
Suggested change
| LoadStr(config.catalog.rest_url, "catalog_rest_url"); | |
| LoadStr(config.catalog.rest_warehouse_id, "catalog_rest_warehouse_id"); | |
| #ifdef USE_REST | |
| LoadStr(config.catalog.rest_url, "catalog_rest_url"); | |
| LoadStr(config.catalog.rest_warehouse_id, "catalog_rest_warehouse_id"); | |
| #endif |
Contributor
There was a problem hiding this comment.
There are some other places where #ifdef USE_REST is missing also
Contributor
There was a problem hiding this comment.
We can consider always building with rest, but let's use #ifdef for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to configure TEA using SQL and don't use tea-config.json.
Settings can be got from FDW server options. When there is no
read_config_file=false in FDW server options, setting are read from
tea-config.json.
Not all setting are supported now. Other setting will be added in the future.
Add the StrToCatalogType function, because now string casting to CatalogType is
executed in two functions.