fix(#687): distinguish operation cancellation from query timeouts - #689
Open
cofin wants to merge 4 commits into
Open
fix(#687): distinguish operation cancellation from query timeouts#689cofin wants to merge 4 commits into
cofin wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
+ Coverage 77.38% 77.41% +0.03%
==========================================
Files 476 476
Lines 68211 68266 +55
Branches 9385 9403 +18
==========================================
+ Hits 52782 52846 +64
+ Misses 12022 12015 -7
+ Partials 3407 3405 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cofin
force-pushed
the
fix/adbc-error-trap
branch
from
August 8, 2026 18:16
8a07382 to
896923b
Compare
… coercion, and docs framing fixes
… coercion, and docs framing fixes
cofin
force-pushed
the
fix/adbc-error-trap
branch
from
August 8, 2026 23:39
896923b to
c5d0088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OperationCancelledErroras a sibling ofQueryTimeoutError57014asOperationalErrorunless native status or message evidence identifies the causeRoot cause
The shared exception contract grouped explicit caller or operator cancellation with elapsed query timeouts. That lost native distinctions such as ADBC
CANCELLEDversusTIMEOUTand caused callers catchingQueryTimeoutErrorto receive user-initiated cancellation as though a deadline had elapsed.The shared message classifier now checks timeout markers first because server messages such as
canceling statement due to statement timeoutcontain both cancellation and timeout language.Closes #687