feat(data-dictionary): co-locate dialect packages and consolidate domain SQL - #688
Open
cofin wants to merge 2 commits into
Open
feat(data-dictionary): co-locate dialect packages and consolidate domain SQL#688cofin wants to merge 2 commits into
cofin wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 77.38% 77.35% -0.03%
==========================================
Files 476 486 +10
Lines 68211 68265 +54
Branches 9385 9396 +11
==========================================
+ Hits 52782 52809 +27
- Misses 12022 12042 +20
- Partials 3407 3414 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cofin
force-pushed
the
feat/data-dictionary-sql-consolidation
branch
from
August 8, 2026 20:43
2a0d8b7 to
e4b20c8
Compare
cofin
force-pushed
the
feat/data-dictionary-sql-consolidation
branch
from
August 8, 2026 23:39
e4b20c8 to
650738a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the data dictionary subsystem in
sqlspec/data_dictionary/to co-locate Python dialect modules and SQL query files into package directories per database engine.Changes Included
sqlspec/data_dictionary/dialects/<dialect>.pyinto package directoriessqlspec/data_dictionary/dialects/<dialect>/containingconfig.py(defines<DIALECT>_CONFIG) and__init__.py(re-exports config & helpers)..sqlquery files (columns.sql,tables.sql,indexes.sql, etc.) insidesqlspec/data_dictionary/dialects/<dialect>/sql/.DataDictionaryLoaderin_loader.pyto lazy-load domain.sqlfiles viaimportlib.resources.files(f"sqlspec.data_dictionary.dialects.{dialect}.sql").joinpath(f"{domain}.sql").sqlspec/data_dictionary/sql/directory tree.Quality Gates
make lintpassed (ruff lint, format, mypy, pyright, slotscheck, codespell, zizmor).uv run pytest tests/unit/data_dictionary/passed (125/125 unit tests green).