Let SELKIES_DEBUG show the desktop session's output - #188
Open
junkerderprovinz wants to merge 1 commit into
Open
Let SELKIES_DEBUG show the desktop session's output#188junkerderprovinz wants to merge 1 commit into
junkerderprovinz wants to merge 1 commit into
Conversation
The session scripts sent their own output to /dev/null unconditionally, so autostart failures and the ready banner never reached the container log. SELKIES_DEBUG is documented but was not wired to anything. svc-de/run opens the destination while it is still root and both entrypoints inherit the descriptor across s6-setuidgid, so abc never opens /dev/stdout itself and the choice lives in one place instead of in each session script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176.
Following up on the approach I described in the issue.
svc-de/runopens the destination while it is still root, and both entrypoints inherit that descriptor acrosss6-setuidgid. Soabcnever opens/dev/stdoutitself, which was the blocker on the earlier attempt, and the conditional sits in one place rather than in each session script.Verified the inheritance holds:
while the same user opening
/dev/stdoutdirectly still getsPermission denied.SELKIES_DEBUGis documented in the README but was not wired to anything before this; with it off, behaviour is unchanged.