Skip to content

fix(session): avoid tty control in Treeland #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zccrs merged 1 commit into from
Jun 11, 2026
Merged

fix(session): avoid tty control in Treeland #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/daemon/UserSession.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,19 @@ namespace DDM {
void UserSession::childModifier() {
Auth *auth = qobject_cast<Auth *>(parent());

// When the display server is part of the session, we leak the VT into
// the session as stdin so that it stays open without races
// When the display server is part of the session, leak the VT into
// the session as stdin so that it stays open without races. Treeland
// single-mode sessions run under an already active compositor, so they
// must not take the VT as their controlling terminal.
if (auth->type != Display::X11) {
// open VT and get the fd
QString ttyString = TtyUtils::path(auth->tty);
int vtFd = ::open(qPrintable(ttyString), O_RDWR | O_NOCTTY);
QString ttyString;
int vtFd = -1;

if (auth->type != Display::Treeland) {
// open VT and get the fd
ttyString = TtyUtils::path(auth->tty);
vtFd = ::open(qPrintable(ttyString), O_RDWR | O_NOCTTY);
}

// when this is true we'll take control of the tty
bool takeControl = false;
Expand Down
Loading