Skip to content

feat(vpn): Add dependency libpolkit-qt6-1-dev in control#564

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
52cyb:master
Jun 12, 2026
Merged

feat(vpn): Add dependency libpolkit-qt6-1-dev in control#564
mhduiy merged 1 commit into
linuxdeepin:masterfrom
52cyb:master

Conversation

@52cyb

@52cyb 52cyb commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Add dependency libpolkit-qt6-1-dev in control.

新增依赖 libpolkit-qt6-1-dev ,处理编译打包错误,支持 Polkit 权限认证。

Log: 新增依赖libpolkit-qt6-1-dev
PMS: BUG-355287
Influence: 正确编译打包

Summary by Sourcery

Add missing polkit-related development dependency to the Debian packaging metadata to enable successful builds.

Bug Fixes:

  • Fix Debian package build failures caused by a missing libpolkit-qt6-1-dev dependency.

Build:

  • Declare libpolkit-qt6-1-dev as a required dependency in debian/control to support polkit-based permission handling.

Add dependency libpolkit-qt6-1-dev in control.

新增依赖 libpolkit-qt6-1-dev ,处理编译打包错误,支持 Polkit 权限认证。

Log: 新增依赖libpolkit-qt6-1-dev
PMS: BUG-355287
Influence: 正确编译打包
@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds libpolkit-qt6-1-dev as a build dependency in debian/control to fix build/package errors and enable Polkit-based privilege authorization support for the VPN component.

File-Level Changes

Change Details Files
Add libpolkit-qt6-1-dev as a build dependency for the VPN package to support Polkit-based authorization and resolve build issues.
  • Update the debian/control file to include libpolkit-qt6-1-dev in the appropriate Depends/Build-Depends field for the VPN-related package
  • Aligns packaging metadata with the codebase’s use of Polkit-Qt6 so builds no longer fail due to missing development headers and libraries
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mhduiy mhduiy merged commit 046fa58 into linuxdeepin:master Jun 12, 2026
15 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 52cyb, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

Hi @52cyb. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants