fix: change cross-app accessed dconfig items from private to public - #279
Open
18202781743 wants to merge 1 commit into
Open
fix: change cross-app accessed dconfig items from private to public#27918202781743 wants to merge 1 commit into
18202781743 wants to merge 1 commit into
Conversation
The following config items are accessed by applications other than the owner appId, so their visibility should be public instead of private: - Background_Uris: accessed by dde-session-ui (welcome, wm-chooser) - Wallpaper_Uris: accessed by dde-file-manager (background) - Wallpaper_Slideshow: accessed by dde-services (wallpaperslideshow) - Global_Theme: accessed by dde-services (thememanager) - Sound_Theme: accessed by dde-session (sessionmanager) Serial bumped from 0 to 1 for each changed item. PMS: BUG-000000
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts DConfig permissions for dde-appearance entries that are accessed across applications, changing them from private to public so other apps can successfully read them, with supporting identity/fingerprint handling occurring in related PRs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review★ 总体评分：95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 --- a/misc/dconfig/org.deepin.dde.appearance.json
+++ b/misc/dconfig/org.deepin.dde.appearance.json
@@ -34,13 +34,13 @@
},
"Wallpaper_Slideshow": {
"value": "",
- "serial": 0,
+ "serial": 1,
"flags": [],
"name": "Wallpaper_Slideshow",
"name[zh_CN]": "*****",
- "description": "",
+ "description": "Configuration for wallpaper slideshow settings",
"permissions": "readwrite",
- "visibility": "private"
+ "visibility": "public"
}, |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Double-check that only the keys actually required by other apps were switched from private to public, and that no newly exposed items include sensitive or user-identifying data.
- Consider adding a brief inline comment or grouping in the dconfig JSON to clearly distinguish cross-app public items from those intended to remain app-local, to reduce future accidental exposure.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that only the keys actually required by other apps were switched from private to public, and that no newly exposed items include sensitive or user-identifying data.
- Consider adding a brief inline comment or grouping in the dconfig JSON to clearly distinguish cross-app public items from those intended to remain app-local, to reduce future accidental exposure.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: change cross-app accessed dconfig items from private to public
变更说明
具体修改的配置项
技术方案简述
关联的其他 PR
Summary by Sourcery
Bug Fixes: