block: remove redundant GD_NEED_PART_SCAN in add_disk_final()#966
Open
blktests-ci[bot] wants to merge 2 commits into
Open
block: remove redundant GD_NEED_PART_SCAN in add_disk_final()#966blktests-ci[bot] wants to merge 2 commits into
blktests-ci[bot] wants to merge 2 commits into
Conversation
Author
|
Upstream branch: 062871f |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
e48f9db to
199644a
Compare
Author
|
Upstream branch: 5b33fc6 |
blktests-ci
Bot
force-pushed
the
series/1111700=>linus-master
branch
from
faecb57 to
6e7b4cd
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
199644a to
e6d9eb8
Compare
Author
|
Upstream branch: 66affa3 |
blktests-ci
Bot
force-pushed
the
series/1111700=>linus-master
branch
from
6e7b4cd to
06c106c
Compare
Author
|
Upstream branch: 66affa3 |
blktests-ci
Bot
force-pushed
the
series/1111700=>linus-master
branch
from
06c106c to
88b4f03
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
e6d9eb8 to
7d8604f
Compare
Author
|
Upstream branch: bade58e |
blktests-ci
Bot
force-pushed
the
series/1111700=>linus-master
branch
from
88b4f03 to
c9698f1
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7d8604f to
4cc45a3
Compare
Author
|
Upstream branch: 4edcdef |
blktests-ci
Bot
force-pushed
the
series/1111700=>linus-master
branch
from
c9698f1 to
42b2434
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
4cc45a3 to
90ffd56
Compare
Author
|
Upstream branch: dc59e4f |
blktests-ci
Bot
force-pushed
the
series/1111700=>linus-master
branch
from
42b2434 to
e64be54
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
90ffd56 to
d52f35a
Compare
Author
|
Upstream branch: 87320be |
blktests-ci
Bot
force-pushed
the
series/1111700=>linus-master
branch
from
e64be54 to
24c0961
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
d52f35a to
a644c13
Compare
add_disk_final() sets GD_NEED_PART_SCAN before calling bdev_add(), then calls disk_scan_partitions() which sets the flag itself. The early set is redundant and introduces a race. Between bdev_add() and disk_scan_partitions(), concurrent openers (multipathd, blkid, LVM) see the flag in blkdev_get_whole() and trigger bdev_disk_changed(). When disk_scan_partitions() then runs, it calls bdev_disk_changed() again, dropping the partitions the concurrent opener already created before re-adding them, which can result in transient partition disappearances. The race is observable by inserting an msleep() between bdev_add() and disk_scan_partitions() while running concurrent open() calls during device bind. Without artificial delay, it manifests under scheduling pressure during boot on systems with aggressive device scanners (multipathd, systemd-udevd). Therefore, do not set GD_NEED_PART_SCAN in add_disk_final(). Other GD_NEED_PART_SCAN consumers (blkdev_get_whole(), sd_need_revalidate()) should not be affected as the flag is set internally by disk_scan_partitions(). The retry-on-next-open intention from commit e5cfefa ("block: fix scan partition for exclusively open device again") should also not be affected as the early return paths in disk_scan_partitions() should be unreachable at device registration time (bd_holder is NULL and open_partitions is zero). Fixes: e5cfefa ("block: fix scan partition for exclusively open device again") Cc: stable@vger.kernel.org Signed-off-by: Connor Williamson <connordw@amazon.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Author
|
Upstream branch: 8cdeaa5 |
blktests-ci
Bot
force-pushed
the
series/1111700=>linus-master
branch
from
24c0961 to
f660739
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
a644c13 to
a2204c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: block: remove redundant GD_NEED_PART_SCAN in add_disk_final()
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1111700