block: rust: fix Send bound for GenDisk#952
Open
blktests-ci[bot] wants to merge 2 commits into
Open
Conversation
Author
|
Upstream branch: 9716c08 |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
c3a084b to
5f78e5d
Compare
Author
|
Upstream branch: 2a2974b |
blktests-ci
Bot
force-pushed
the
series/1109585=>linus-master
branch
from
789ce38 to
a634efa
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
5f78e5d to
e48f9db
Compare
Author
|
Upstream branch: 062871f |
blktests-ci
Bot
force-pushed
the
series/1109585=>linus-master
branch
from
a634efa to
ef83346
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
2 times, most recently
from
199644a to
e6d9eb8
Compare
Author
|
Upstream branch: 66affa3 |
blktests-ci
Bot
force-pushed
the
series/1109585=>linus-master
branch
from
ef83346 to
a9662f2
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
e6d9eb8 to
7d8604f
Compare
Author
|
Upstream branch: bade58e |
blktests-ci
Bot
force-pushed
the
series/1109585=>linus-master
branch
from
a9662f2 to
8d5e586
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7d8604f to
4cc45a3
Compare
Author
|
Upstream branch: 4edcdef |
blktests-ci
Bot
force-pushed
the
series/1109585=>linus-master
branch
from
8d5e586 to
0ebeb33
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
4cc45a3 to
90ffd56
Compare
Author
|
Upstream branch: dc59e4f |
blktests-ci
Bot
force-pushed
the
series/1109585=>linus-master
branch
from
0ebeb33 to
c1c5e35
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
90ffd56 to
d52f35a
Compare
Author
|
Upstream branch: 87320be |
blktests-ci
Bot
force-pushed
the
series/1109585=>linus-master
branch
from
c1c5e35 to
bf0c89a
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
d52f35a to
a644c13
Compare
The `Send` implementation for `GenDisk<T>` was conditioned on `T: Send`. This constrains the wrong type. `T` is the `Operations` implementation, which is typically a zero-sized marker type that carries no data, so `T: Send` says nothing about whether the data a `GenDisk` actually owns can be moved to another thread. A `GenDisk<T>` owns the queue data `T::QueueData` (stored as the `gendisk`'s `queuedata` and dropped when the `GenDisk` is dropped) and an `Arc<TagSet<T>>`. These are the values transferred when a `GenDisk` is sent across a thread boundary, so the `Send` bound must constrain exactly them. Bound `T::QueueData: Send` and `Arc<TagSet<T>>: Send` instead. Fixes: 3253aba ("rust: block: introduce `kernel::block::mq` module") Reported-by: Priya Bala Govindasamy <pgovind2@uci.edu> Reported-by: Dylan Zueck <dzueck@uci.edu> Suggested-by: Andreas Hindborg <a.hindborg@kernel.org> Signed-off-by: Yuan Tan <ytan089@ucr.edu>
Author
|
Upstream branch: 8cdeaa5 |
blktests-ci
Bot
force-pushed
the
series/1109585=>linus-master
branch
from
bf0c89a to
2c10400
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
a644c13 to
a2204c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: block: rust: fix
Sendbound forGenDiskversion: 3
url: https://patchwork.kernel.org/project/linux-block/list/?series=1109585