TPT-4126: Add support for NB Front-End IP in VPC-MTC + 40Gbps NB-MTC by mawilk90 · Pull Request #978 · linode/linodego

mawilk90 · 2026-05-26T07:36:11Z

📝 Description

This PR merges support for NB Front-End IP + 40Gbps features into the main branch for release.

NOTE:

Waiting for info from TechDoc if it can be merged/released before their NB changes (planned to be available in Sep)
This PR is dependent on it

✔️ How to Test

make test-unit
make test-int TEST_ARGS="-run TestNodeBalancer_Create_With"

* Added support for NB Frontend VPC IP * Address CoPilot suggestions * Removed unnecessary omitempty

* Use dynamic capabilities in createVPCWithSubnet * Modify TestNodeBalancer_Create_with_vpc to cover NB Front-End IP * Add tests for frontend VPCs in single stack * Update capabilities in createVPCWithSubnet and createVPCWithDualStackSubnet * Add func getIntersection * Add tests for premium40gb and different VPCs * Create func createVPCWithDualStackSubnetInRegion * Rename fixture in TestNodeBalancer_Create_WithBackendVPCOnly * Extract setup functions for premium NBs * Clean-up * Refactor TestNodeBalancer_Create_WthFrontendVPC to use setupNodeBalancerWithFrontendVPC * Generate fixtures with make * Rename expected to fail tests * Comment out expected to fail tests * Add two more checks to TestNodeBalancer_Create_WithFrontendVPCOnly * Solve PR remarks * Solve PR remarks * Update setupInstanceWithDualStackVPCAndNAT11 to fix failing TestVPC_List*IPv6Addresses * Add recordStopper and fixtures to expected-to-fail tests * Add t.Skip in getValidRegion in case there is no valid regions * PR review remarks: replace assert.Emtpy with assert.Nil * Linter fix

* TPT-4329 Deprecate vpcs in favor of backend_vpcs * TPT-4329 Create specific type for NB Backend VPC

…eate (#926) * TPT-4329 Deprecate vpcs in favor of backend_vpcs * TPT-4329 Create specific type for NB Backend VPC * Replace VPCs with BackendVPCs to be passed to POST /nodebalancers * Refactor tests to use newly added type for NB Backend VPC * Copilot remarks fixes --------- Co-authored-by: Dawid Dzhafarov <ddzhafar@akamai.com>

…p-in-vpc

Copilot

Pull request overview

This PR extends linodego’s NodeBalancer support to cover (1) Premium 40Gbps plans and (2) NodeBalancer front-end IPs in VPC, including new VPC config list/get endpoints and corresponding unit/integration fixtures/tests.

Changes:

Add NodeBalancer fields and create options for frontend_vpcs, backend_vpcs (plus deprecated vpcs) and the new premium_40gb plan type.
Add NodeBalancer VPC config purpose support and client methods to list/get configs from /vpcs, /backend_vpcs, and /frontend_vpcs.
Expand unit/integration test coverage and fixtures for the new NodeBalancer/VPC behaviors.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
`nodebalancer.go`	Adds NodeBalancer front-end VPC fields, new plan type constant, and create options for frontend/backend VPCs.
`nodebalancer_config_vpc.go`	Adds VPC config `purpose` plus new list endpoints for backend/frontend configs.
`test/unit/nodebalancer_test.go`	Updates unit tests/fixtures assertions for the new NB fields/type and adds create tests for VPC options.
`test/unit/nodebalancer_config_vpc_test.go`	Adds unit tests for NodeBalancer VPC config list/get endpoints.
`test/unit/fixtures/nodebalancers_list.json`	Updates list fixture to include `type` and front-end VPC fields.
`test/unit/fixtures/nodebalancer_get.json`	Updates get fixture to include `type` and front-end VPC fields.
`test/unit/fixtures/nodebalancer_create_with_vpcs.json`	Adds create fixture for NB with backend/frontend VPCs.
`test/unit/fixtures/nodebalancer_vpc_config_*.json`	Adds fixtures for VPC config list/get endpoints.
`test/integration/nodebalancers_test.go`	Adds integration tests for frontend/backend VPC scenarios and premium_40gb.
`test/integration/vpc_subnet_test.go`	Ensures VPC setup selects regions with NodeBalancer capability.
`test/integration/instance_config_test.go`	Updates region selection to use capability filtering (no hardcoded region).
`test/integration/util_test.go`	Adds generic `getIntersection` helper used for region selection.
`test/integration/fixtures/TestNodeBalancer_*.yaml`	Adds recorded fixtures for new integration test scenarios.

Comments suppressed due to low confidence (1)

test/unit/nodebalancer_test.go:99

This test’s expectations depend on the position of the test case in tests (via idx), making it brittle if the table ordering changes. Prefer branching on a stable attribute (e.g., tt.fixture) or adding explicit expected fields to the table.

	for idx, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			fixtureData, err := fixtures.GetFixture(tt.fixture)
			assert.NoError(t, err)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…p-in-vpc

…DeprecatedVPCsAttribute

ezilber-akamai · 2026-07-30T17:53:53Z

 }

+type NodeBalancerBackendVPCOptions struct {
+	IPv4Range           string `json:"ipv4_range,omitzero"`


Should this be a pointer?

ezilber-akamai · 2026-07-30T17:54:04Z


+type NodeBalancerBackendVPCOptions struct {
+	IPv4Range           string `json:"ipv4_range,omitzero"`
+	IPv6Range           string `json:"ipv6_range,omitzero"`


ezilber-akamai · 2026-07-30T17:54:09Z

+	IPv4Range           string `json:"ipv4_range,omitzero"`
+	IPv6Range           string `json:"ipv6_range,omitzero"`
+	SubnetID            int    `json:"subnet_id"`
+	IPv4RangeAutoAssign bool   `json:"ipv4_range_auto_assign,omitzero"`


ezilber-akamai · 2026-07-30T17:54:15Z

+}
+
+type NodeBalancerFrontendVPCOptions struct {
+	IPv4Range string `json:"ipv4_range,omitzero"`


ezilber-akamai · 2026-07-30T17:54:20Z

+
+type NodeBalancerFrontendVPCOptions struct {
+	IPv4Range string `json:"ipv4_range,omitzero"`
+	IPv6Range string `json:"ipv6_range,omitzero"`


Hi @ezilber-akamai, all the fields you mentioned above (IPv4Range, IPv6Range, IPv4RangeAutoAssign) seems to be optional and can be skipped in the API request. Does it mean that they need to be a pointers for omitzero anyway? In the current implementation, aren't both "" and lack of these fields treated the same?

ezilber-akamai and others added 4 commits March 5, 2026 08:58

Added support for NB Frontend VPC IP (#907)

628a1c3

* Added support for NB Frontend VPC IP * Address CoPilot suggestions * Removed unnecessary omitempty

TPT-4329: Deprecate vpcs in favor of backend_vpcs (#924)

0f4c797

* TPT-4329 Deprecate vpcs in favor of backend_vpcs * TPT-4329 Create specific type for NB Backend VPC

mawilk90 added the project for new projects in the changelog. label May 26, 2026

mawilk90 added 2 commits May 27, 2026 15:32

Merge remote-tracking branch 'upstream/main' into proj/nb-front-end-i…

7723b38

…p-in-vpc

Fix unit test for nb with lke cluster

65ea54e

mawilk90 marked this pull request as ready for review May 27, 2026 14:30

mawilk90 requested a review from a team as a code owner May 27, 2026 14:30

Copilot AI review requested due to automatic review settings May 27, 2026 14:30

mawilk90 requested a review from a team as a code owner May 27, 2026 14:30

mawilk90 requested review from ezilber-akamai and psnoch-akamai and removed request for a team May 27, 2026 14:30

Copilot started reviewing on behalf of mawilk90 May 27, 2026 14:30 View session

Copilot AI reviewed May 27, 2026

View reviewed changes

mawilk90 added 2 commits May 28, 2026 10:17

Merge remote-tracking branch 'upstream/main' into proj/nb-front-end-i…

1a24329

…p-in-vpc

Fix linters

17068fd

mawilk90 changed the title ~~TPT-4126: Project NB Front-End IP in VPC-MTC + 40Gbps NB-MTC~~ Project: Add support for NB Front-End IP in VPC-MTC + 40Gbps NB-MTC May 28, 2026

mawilk90 requested review from lgarber-akamai and zliang-akamai May 28, 2026 08:53

Merge branch 'main' into proj/nb-front-end-ip-in-vpc

52f201e

mawilk90 marked this pull request as draft June 1, 2026 08:27

mawilk90 changed the title ~~Project: Add support for NB Front-End IP in VPC-MTC + 40Gbps NB-MTC~~ TPT-4126: Add support for NB Front-End IP in VPC-MTC + 40Gbps NB-MTC Jun 1, 2026

mawilk90 added 3 commits July 17, 2026 12:30

Merge branch 'main' into proj/nb-front-end-ip-in-vpc

02e0644

Fix issue with no-premium region used in TestNodeBalancer_Create_With…

35d0ed3

…DeprecatedVPCsAttribute

Update fixtures

25bfd3a

mawilk90 removed the request for review from lgarber-akamai July 17, 2026 14:16

mawilk90 added the do-not-merge PRs that should not be merged until the commented issue is resolved label Jul 17, 2026

mawilk90 marked this pull request as ready for review July 17, 2026 14:17

mawilk90 mentioned this pull request Jul 17, 2026

TPT-4126: Project NB Front-End IP in VPC-MTC + 40Gbps NB-MTC linode/terraform-provider-linode#2415

Open

Merge branch 'main' into proj/nb-front-end-ip-in-vpc

7773999

ezilber-akamai reviewed Jul 30, 2026

View reviewed changes

Merge branch 'main' into proj/nb-front-end-ip-in-vpc

5f40400

Navigation Menu

Uh oh!

TPT-4126: Add support for NB Front-End IP in VPC-MTC + 40Gbps NB-MTC - #978

TPT-4126: Add support for NB Front-End IP in VPC-MTC + 40Gbps NB-MTC#978
mawilk90 wants to merge 14 commits into
mainfrom
proj/nb-front-end-ip-in-vpc

mawilk90 commented May 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ezilber-akamai Jul 30, 2026

Uh oh!

ezilber-akamai Jul 30, 2026

Uh oh!

ezilber-akamai Jul 30, 2026

Uh oh!

ezilber-akamai Jul 30, 2026

Uh oh!

ezilber-akamai Jul 30, 2026

Uh oh!

mawilk90 Aug 10, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mawilk90 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ezilber-akamai Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

ezilber-akamai Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

ezilber-akamai Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

ezilber-akamai Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

ezilber-akamai Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

mawilk90 Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mawilk90 commented May 26, 2026 •

edited

Loading

mawilk90 Aug 10, 2026 •

edited

Loading