TPT-4462: Add test for RDMA Linode instance creation - #733
Open
mawilk90 wants to merge 1 commit into
Open
Conversation
mawilk90
requested review from
jriddle-linode,
lgarber-akamai,
psnoch-akamai and
yec-akamai
and
a lite review from Copilot
and removed request for
a team and
jriddle-linode
August 19, 2026 15:11
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an (currently skipped) integration test intended to validate creation of Linode instances configured with RDMA VPC interfaces, plus supporting fixtures/helpers to create RDMA VPC resources in a consistent region.
Changes:
- Add helpers and a new (skipped) integration test for creating a Linode with multiple RDMA VPC interfaces plus a regular VPC interface.
- Extend integration fixtures to reuse a chosen VPC region across VPC and RDMA-VPC creation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/integration/models/linode/interfaces/test_interfaces.py | Adds RDMA interface builders and a skipped test for RDMA Linode instance creation using Linode interfaces. |
| test/integration/conftest.py | Introduces a shared VPC region variable to align region selection between VPC and RDMA VPC fixtures. |
Suppressed comments (1)
test/integration/models/linode/interfaces/test_interfaces.py:520
firewall_id=-1will be sent to the API as an invalid firewall ID. If the intent is “no firewall”, passNone(the key will still be included due toalways_include).
firewall_id=-1,
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
yec-akamai
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Additional test case for RDMA linode instance creation with linodepy
Note:
test_linode_interfaces_with_rdma_vpc_typeis marked as skipped because it requires manual infra changes✔️ How to Test
make test-int TEST_ARGS="-k test_linode_interfaces_with_rdma_vpc_type"